Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 113.0.5672.63 to Chromium 113.0.5672.77 #18337

Merged
merged 5 commits into from
May 3, 2023
Merged

Upgrade from Chromium 113.0.5672.63 to Chromium 113.0.5672.77 #18337

merged 5 commits into from
May 3, 2023

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented May 2, 2023

Resolves brave/brave-browser#30096

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/run-network-audit Run network-audit CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) labels May 2, 2023
@mkarolin mkarolin self-assigned this May 2, 2023
@mkarolin mkarolin requested review from a team as code owners May 2, 2023 21:15
@mkarolin
Partially revert PR 18301.
6efe19e 
The partial revert is needed because Chromium 113.0.5672.77 was branched
from Chromium 113.0.5672.62, so it's missing the changes made in
Chromium 113.0.5672.63, which is what we have currently.

This revert will need to be reverted back with the next Chromium bump.
@mkarolin mkarolin requested a review from a team as a code owner May 3, 2023 02:38
@kjozwiak kjozwiak self-requested a review May 3, 2023 06:14
kjozwiak
kjozwiak approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 CI passed on all platforms.

@kjozwiak kjozwiak merged commit efe9291 into master May 3, 2023
@kjozwiak kjozwiak deleted the 113.0.5672.77_master branch May 3, 2023 06:14
@github-actions github-actions bot added this to the 1.53.x - Nightly milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diracdeltas diracdeltas diracdeltas approved these changes

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@mkarolin mkarolin

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux)
Projects
None yet
Milestone
1.56.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 113.0.5672.63 to Chromium 113.0.5672.77.
4 participants
@mkarolin @diracdeltas @kjozwiak @brave-builds