Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 114.0.5735.35 to Chromium 114.0.5735.53 #18616

Merged
merged 4 commits into from
May 26, 2023
Merged

Upgrade from Chromium 114.0.5735.35 to Chromium 114.0.5735.53 #18616

merged 4 commits into from
May 26, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented May 25, 2023

Resolves brave/brave-browser#30588

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick added this to the 1.54.x - Nightly milestone May 25, 2023
@emerick emerick requested a review from a team May 25, 2023 14:59
@emerick emerick self-assigned this May 25, 2023
@emerick emerick requested review from a team as code owners May 25, 2023 14:59
@github-actions github-actions bot added CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit labels May 25, 2023
@samartnik
[Android] Clean up code for BraveTabSwitcherModeTopToolbar.mToggleTab…
bd7b856 
…StackButton

Chromium change:
https://chromium.googlesource.com/chromium/src/+/d422158bc1109201e9ba59ef20b1d2285b58cc44

[A11y] Hide tab switcher button in a11y list tab switcher

Hide tab switcher button in a11y list tab switcher.
-Tab switcher toolbar no longer shows this button, so it's been removed.

(cherry picked from commit 650061ccbc4dd02957c60aafa24f15a1c223cd72)

Bug: 1445874
@samartnik samartnik requested a review from a team as a code owner May 25, 2023 16:54
kjozwiak
kjozwiak approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging into master so we can uplift into 1.53.x & 1.52.x via #18615 & #18613 and kick off new 1.52.x RC builds.

@kjozwiak kjozwiak merged commit 8fba62b into master May 26, 2023
@kjozwiak kjozwiak deleted the 114.0.5735.53_master branch May 26, 2023 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@emerick emerick

Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) CI/run-network-audit Run network-audit
Projects
None yet
Milestone
1.57.x - Release
Development

Successfully merging this pull request may close these issues.

Upgrade from Chromium 114.0.5735.35 to Chromium 114.0.5735.53
4 participants
@emerick @kjozwiak @brave-builds @samartnik