-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wallet): introduce swap protocol fees #19834
Conversation
19a4c96
to
1360135
Compare
auto protocol_fee_pct = percentage_fee.value() * 0; | ||
auto brave_fee_pct = percentage_fee.value() * 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines will be changed to the following in future:
auto protocol_fee_pct = percentage_fee.value() * 0.2;
auto brave_fee_pct = percentage_fee.value() * 0.8;
wallet core LGTM |
A Storybook has been deployed to preview UI for the latest push |
components/brave_wallet_ui/page/screens/swap/components/swap/quote-info/quote-info.tsx
Show resolved
Hide resolved
components/brave_wallet_ui/page/screens/swap/components/swap/quote-info/quote-info.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS++
Opened brave/brave-ios#7924 for iOS front-end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
Includes some refactoring to allow dynamic computation of fees, offer discounts, etc., in the near future.
Resolves brave/brave-browser#32464
Resolves brave/brave-browser#31855
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: