Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting problem in build-bisect script #1997

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Fix formatting problem in build-bisect script #1997

merged 1 commit into from
Mar 18, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Mar 18, 2019 •
edited
Loading

Description

No issue for this; but you can see a failure here:
https://travis-ci.org/brave/brave-core/builds/508040774?utm_source=github_status&utm_medium=notification

Caused the original commit - I didn't run npm run pep8:
#1833

@bsclifton bsclifton added this to the 0.64.x - Nightly milestone Mar 18, 2019
@bsclifton bsclifton self-assigned this Mar 18, 2019
mbacchi
mbacchi approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@mbacchi mbacchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to run pep8 too. Good catch.

@bsclifton bsclifton merged commit 6e960e9 into master Mar 18, 2019
@bsclifton bsclifton deleted the fix-bisect-lint branch March 18, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbacchi mbacchi mbacchi approved these changes

@mihaiplesa mihaiplesa Awaiting requested review from mihaiplesa

@cezaraugusto cezaraugusto Awaiting requested review from cezaraugusto

Assignees

@bsclifton bsclifton

Labels
None yet
Projects
None yet
Milestone
0.64.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@bsclifton @mbacchi