Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vpn button still has connected state for not purchased user #20533

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Oct 16, 2023

Resolves brave/brave-browser#33023

When purchased state is changed to not purchased during the runtime, button should not show as connected.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue for manual test.
BraveVpnButtonUnitTest.ButtonStateTestWithPurchasedState

@simonhong simonhong self-assigned this Oct 16, 2023
@simonhong simonhong marked this pull request as ready for review October 16, 2023 04:13
@simonhong simonhong force-pushed the vpn_button_state_purchased_state branch from a92ba0c to e6ea612 Compare October 16, 2023 05:33
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

fix brave/brave-browser#33023

When purchased state is changed to *not* purchased during the runtime,
button should not show as connected.
@simonhong simonhong force-pushed the vpn_button_state_purchased_state branch from e6ea612 to 8bdee24 Compare October 16, 2023 08:04
@simonhong simonhong merged commit 2aa858d into master Oct 16, 2023
15 checks passed
@simonhong simonhong deleted the vpn_button_state_purchased_state branch October 16, 2023 09:28
@github-actions github-actions bot added this to the 1.61.x - Nightly milestone Oct 16, 2023
@github-actions github-actions bot added the potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false label Oct 16, 2023
simonhong added a commit that referenced this pull request Nov 22, 2023
Fixed vpn button still has connected state for not purchased user
kjozwiak pushed a commit that referenced this pull request Nov 23, 2023
…ift to 1.60.x) (#21083)

* Merge pull request #20386 from brave/button-update

Remove brave vpn toolbar button flashes when reconnecting multiple times

* Merge pull request #20533 from brave/vpn_button_state_purchased_state

Fixed vpn button still has connected state for not purchased user
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPN toolbar button should have disconnected state when changed to not-purchased state during the runtime
2 participants