Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): prevent cointype mismatch in getTokenBalancesRegistry #20589

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

onyb
Copy link
Member

@onyb onyb commented Oct 18, 2023

Resolves brave/brave-browser#32029
Resolves brave/brave-browser#33187

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Portfolio balances should load without any console errors as reported in the linked issues.
  2. Enable localhost EVM network in Web3 settings and view any particular EVM account. It should not result in infinite loading of balances.

@onyb onyb self-assigned this Oct 18, 2023
@onyb onyb requested a review from a team as a code owner October 18, 2023 18:12
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Oct 18, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@onyb onyb enabled auto-merge (squash) October 19, 2023 10:56
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@onyb onyb merged commit 7649c0b into master Oct 19, 2023
15 checks passed
@onyb onyb deleted the f/wallet/optimise-balances branch October 19, 2023 15:26
@github-actions github-actions bot added this to the 1.61.x - Nightly milestone Oct 19, 2023
onyb added a commit that referenced this pull request Oct 19, 2023
…20589)

* fix(wallet): prevent cointype mismatch in getTokenBalancesRegistry

* review(JL): fixes
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.61.50 Chromium: 119.0.6045.33 (Official Build) nightly (64-bit)
Revision af3c0e1
OS Linux
  • Verified steps from PR
  • Verified no error message in console when using the wallet, loading balance/NFT, loading graph
  • Verified balance is loaded successfully when loading localhost EVM account

kjozwiak pushed a commit that referenced this pull request Oct 25, 2023
…plift to 1.60.x) (#20608)

fix(wallet): prevent cointype mismatch in getTokenBalancesRegistry (#20589)

* fix(wallet): prevent cointype mismatch in getTokenBalancesRegistry

* review(JL): fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
4 participants