Tokens that fail to redeem due to network errors should be added to a queue and retried #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
reviewed
Mar 26, 2019
| }; | ||
|
|
||
| ConfirmationType() = default; | ||
| constexpr ConfirmationType(const Value value) : value_(value) {} |
There was a problem hiding this comment.
lint error here, Single-parameter constructors should be marked explicit. [runtime/explicit] [5]
There was a problem hiding this comment.
as we discussed in slack, I'm fine with NOLINT and a comment stating that we allow implicit conversion from enum value to this wrapper class, similar as https://cs.chromium.org/chromium/src/v8/src/wasm/value-type.h?rcl=88a0c6d607cf023a5776193fe1786be0ca9c0767&l=64-65.
There was a problem hiding this comment.
👍 added NOLINT and comment as above, thanks
| }; | ||
|
|
||
| ConfirmationType() = default; | ||
| constexpr ConfirmationType(const Value value) : value_(value) {} |
There was a problem hiding this comment.
👍 added NOLINT and comment as above, thanks
tmancey
force-pushed
the
issues/3662
branch
3 times, most recently
from
a82f845
to
4f25fb3
Compare
… queue and retried
This was referenced Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes brave/brave-browser#3662
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security) onnpm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Confirm failed requests are added to the
Defaults/rewards_service/confirmations.jsonunderconfirmations/failed_confirmationsand confirmation redemption is retried every 5 minutes +/- jitter until successful. Items that are retried and fail should move to the back of the queue.Reviewer Checklist: