Use brave-browser-stable as the /usr/bin/ symlink for release packages #2083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes brave/brave-browser#1324 by ensuring that the release Debian package can also provide an alternative (of higher priority) for the /usr/bin/brave-browser binary.
With this in place, that binary will default to the release browser and it can be configured normally using:
As noted previously, the RPMs don't need to be fixed since they already exhibit the correct behavior.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
I tested the following "upgrade" scenario on Ubuntu 18.04:
/etc/alternatives/brave-browser which in turn is a symlink to beta.
update-alternatives --config brave-browser
only offers beta.update-alternatives --config brave-browser
offers both stable and beta.apt purge brave-browser
and confirm that/etc/alternatives/brave-browser symlink now points to beta and that
update-alternatives --config brave-browser
only offers beta.and this simpler "new install" scenario:
update-alternatives --config brave-browser
offers only stable.brave-browser
launches the browser.Finally, I built a beta version of this package and ran through this scenario:
update-alternatives --config brave-browser
offers stable and beta.update-alternatives --config brave-browser
also offers stable and beta.Reviewer Checklist: