Only creates dist package for specified channel on linux #209
Conversation
BUILD.gn
Outdated
| if (brave_channel == "") { | ||
| _linux_channel = "stable" | ||
| } else if (brave_channel == "dev") { | ||
| _linux_channel = "unstable" |
There was a problem hiding this comment.
other options for brave_channel are unchanged for linux?
There was a problem hiding this comment.
Yep, beta is used as-is.
nightly is not supported yet on linux and will be added (brave/brave-browser#461)
There was a problem hiding this comment.
can we wrap these things together as I suggested in the other post so brave_channel is corrected for linux in //brave/build/config.gni ?
There was a problem hiding this comment.
Yep, this value and others mentioned in #208 (comment), can be wrapped there.
But I'm not sure we can fetch that values from c++.
There was a problem hiding this comment.
I was thinking a public_config with defines or a generated header file?
There was a problem hiding this comment.
Moved to //brave//build/config.gni. PTAL.
Issue brave/brave-browser#396
With brave/brave-browser#459, we can create dist for all three channels.
Submitter Checklist:
git rebase -ito squash commits (if needed).Test Plan:
yarn create_dist Release --channel=dev-> brave-browser-dev_XXX.deb`Reviewer Checklist: