ai chat: fix summary prompt for pages is being translated #21063
Conversation
| @@ -44,7 +44,8 @@ Here is the conversational history (between the user and you) prior to the quest | |||
| <message name="IDS_AI_CHAT_CLAUDE_QUESTION_PROMPT_SEGMENT" translateable="false"> | |||
| Propose up to 3 very short questions that a reader may ask about the content. Consider intriguing or unusual elements of the content, or structurally important. Separate each suggested question with the character "|". End the question list with a </response> tag.</message> | |||
|
|
|||
| <message name="IDS_AI_CHAT_QUESTION_SUMMARIZE_VIDEO_BULLETS" translateable="false">Provide a concise list of up to 6 bullets of the most important points of the video.</message> | |||
| <message name="IDS_AI_CHAT_QUESTION_SUMMARIZE_PAGE" translateable="false">Provide a concise list of up to 6 bullets on the most important points of the page.</message> | |||
There was a problem hiding this comment.
Is this meant to make the summaries' formats more consistent? Before we were just using "Summarise the page", correct?
One possible suggestion is that we currently treat the page as an article (<article> tags), so referring to it as an article might help. We could also switch that article tag with a page tag since our goal seems to be summarizing/answering on more general types of content, and switch all the language to "page" to be consistent
There was a problem hiding this comment.
Well, yes I was fixing this issue where we're translating this part of the prompt, but then was wondering why we would differ so much from the video summary request. But perhaps I should just fix this issue whereby we don't translate, but keep it as "Summarize this page"?
Unless we think there's definitely an improvement to changing <article to <page, and/or using this more descriptive request for summary?
Now I'm wondering - was there actually value to keeping this part of the prompt translated to the user's UI language? This is the part of the prompt which pretends to be the user, so maybe we should translate those parts? Not sure if that's reliable. We also don't translate the generated suggested questions. And if they're not in a nicely supported language then it could have weird results. Do you agree that we should stop translating this part of the prompt?
There was a problem hiding this comment.
I've changed to <page everywhere, and it seems to be pleasant results in both llama and claude
…mmary prompt for videos, or any other system prompt)
petemill
force-pushed
the
ai-chat-summary-prompt-force-english
branch
from
29ae0ad
to
0ef0d33
Compare
…lish ai chat: fix summary prompt for pages is being translated
…1314) * Merge pull request #21063 from brave/ai-chat-summary-prompt-force-english ai chat: fix summary prompt for pages is being translated * AIChat: new welcome opt-in ux and contextual toggle (#20966) * aichat: new opt-in ux * simplify siteInfo * aichat: toggle page context responses from LLM * moved build site info to conversation driver * special summarize button visibility depends on toggle * MakeAPIRequestWithConversationHistoryUpdate accepts a flag * show model intro on all pages * AI Chat: Don't show suggested questions when conversation isn't associated with content * AI Chat: conversation entry should also be pending if content isn't ready yet --------- Co-authored-by: Pete Miller <[email protected]> --------- Co-authored-by: Pete Miller <[email protected]>
(whereas we're not translating the summary prompt for videos, or any other system prompt)
I think this must have regressed at some point. It was at least planned for.
This does also change the summarisation prompt to suggest bullet points, like we do with video summarisation requests. We can see if there's negative or positive feedback on that.
Resolves brave/brave-browser#34624
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: