Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added auto closing to shields onboarding bubble #21394

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Dec 15, 2023

fix brave/brave-browser#34802

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Launch with clean profile
  2. Load any url that has 1 or more shields blocking (ex, youtube.com)
    3-1. Wait 15s after shields bubble is launched and check bubble is dismissed automatically
    3-2. Click bubble and check bubble is not dismissed even 15s is passed

@simonhong simonhong self-assigned this Dec 15, 2023
@simonhong simonhong marked this pull request as ready for review December 18, 2023 05:41
@@ -25,6 +25,8 @@ namespace {
constexpr int kWidth = 60;
constexpr int kHeight = 60;

constexpr base::TimeDelta kBubbleAutoClosingIntervalInSec = base::Seconds(15);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebron please check 15s timeout is appropriate.

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonhong simonhong merged commit 2f4eb42 into master Dec 20, 2023
22 checks passed
@simonhong simonhong deleted the shields_onboarding_bubble_closing_timer branch December 20, 2023 01:56
@github-actions github-actions bot added this to the 1.63.x - Nightly milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shields onboarding highlight should time out
2 participants