-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SKUs: log the return value of top level functions called from C++ #21543
Conversation
hm looks like this failed as we're using tracing |
Probably for use-after-free in Instrument::into_inner (which we don't call). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
going foward with merge as CI failure is due to unrelated npm audit |
per https://docs.rs/tracing/latest/tracing/attr.instrument.html, this will log the return value of these functions (INFO aka VLOG(2) on success, WARN aka VLOG(1) on failure.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: