Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make claude output formatted code #21599

Merged
merged 2 commits into from
Jan 18, 2024
Merged

make claude output formatted code #21599

merged 2 commits into from
Jan 18, 2024

Conversation

nullhook
Copy link
Contributor

Resolves brave/brave-browser#35380

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@nullhook nullhook requested a review from a team as a code owner January 17, 2024 18:44
Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Jan 17, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@nullhook nullhook merged commit 270a901 into master Jan 18, 2024
18 checks passed
@nullhook nullhook deleted the ai-chat-prompt-changes branch January 18, 2024 17:55
@github-actions github-actions bot added this to the 1.64.x - Nightly milestone Jan 18, 2024
nullhook added a commit that referenced this pull request Jan 18, 2024
brave-builds added a commit that referenced this pull request Jan 18, 2024
@stephendonner
Copy link
Contributor

stephendonner commented Jan 19, 2024

Verification PASSED using

Brave | 1.64.5 Chromium: 121.0.6167.75 (Official Build) nightly (64-bit)
-- | --
Revision | 2bf3fedfbbe00d5306677ee5f480580a4c401018
OS | Windows 10 Version 22H2 (Build 19045.3930)

Steps:

  1. installed 1.64.5
  2. launched Brave
  3. loaded wired.com
  4. clicked on Leo in the sidebar
  5. clicked on Summarize this page
  6. clicked on Accept and begin
  7. typed Write me a "Hello, world!" program in C++
  8. waited for and copied code output
  9. did the same for JavaScript
  10. did the same for Python

Confirmed the code output was correctly formatted inline, as were the "copy code" button's output

C++

before (1.64.3) after (1.64.5)
image image

Copied code sample:

#include <iostream>
using namespace std;

int main() {
  cout << "Hello, World!" << endl; 
  return 0;
}

JavaScript

image

Python

image

kjozwiak pushed a commit that referenced this pull request Jan 19, 2024
* aichat: input is growable (#21124)

* aichat: scroll is interruptable (#21235)

* aichat: model maker text shouldnt look like a link (#21220)

* aichat: code formatting (#21342)

* make claude output formatted code (#21599)
kjozwiak pushed a commit that referenced this pull request Jan 20, 2024
* Merge pull request #21134 from brave/cr121

Upgrade from Chromium 120 to Chromium 121.

* Remove the assert for patch_ffmpeg.py (#21184)

* Merge pull request #21539 from brave/ffmpeg-dynamic-alloc

Use dynamic allocation for ffmpeg fft tables on Windows.

* Merge pull request #21585 from brave/issues/35318

Remove dynamic allocation of ffmpeg ff_tx tables.

* Disables a flaky upstream browser test.

* Merge pull request #21584 from brave/fix_new_tab_button_plus_misaligned

Fixed new tab button's plus icon is mis-aligned with horizontal tab

* Merge pull request #21600 from brave/121.0.6167.75_master

Upgrade from Chromium 121.0.6167.57 to Chromium 121.0.6167.75.

* Merge pull request #21628 from brave/maxk-disable-reading-mode

Hides `Open in Reading Mode` context menu item.

* [Uplift 1.62.x] AI chat issues cr121 1.62.x (#21629)

* aichat: input is growable (#21124)

* aichat: scroll is interruptable (#21235)

* aichat: model maker text shouldnt look like a link (#21220)

* aichat: code formatting (#21342)

* make claude output formatted code (#21599)

---------

Co-authored-by: Mikhail <[email protected]>
Co-authored-by: Aleksey Khoroshilov <[email protected]>
Co-authored-by: Simon Hong <[email protected]>
Co-authored-by: taher <[email protected]>
kjozwiak pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aichat: claude should output formatted code
4 participants