Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Fix interstitial pages #22534

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

Brandon-T
Copy link
Contributor

Summary

  • Fix interstitial pages not showing

Resolves brave/brave-browser#36688

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@Brandon-T Brandon-T added CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Mar 11, 2024
@Brandon-T Brandon-T added this to the 1.65.x - Nightly milestone Mar 11, 2024
@Brandon-T Brandon-T self-assigned this Mar 11, 2024
@Brandon-T Brandon-T requested a review from a team as a code owner March 11, 2024 16:03
@kylehickinson kylehickinson removed this from the 1.65.x - Nightly milestone Mar 11, 2024
@kylehickinson kylehickinson merged commit 7b69efe into master Mar 11, 2024
20 checks passed
@kylehickinson kylehickinson deleted the bugfix/InterstitialPages-iOS branch March 11, 2024 20:24
@github-actions github-actions bot added this to the 1.65.x - Nightly milestone Mar 11, 2024
brave-builds added a commit that referenced this pull request Mar 11, 2024
brave-builds added a commit that referenced this pull request Mar 11, 2024
@kjozwiak
Copy link
Member

Verification PASSED on iPhone 11 running iOS 17.4 using the following build(s):

Chromium | 1.65.76 Chromium: 123.0.6312.29 (Official Build) unknown (64-bit) 
--- | ---
Revision | 9ae60e5e3a26...
OS | iOS

Using the STR/Cases outlined via brave/brave-ios#8789 (comment), reproduced the original issue using 1.61.1 (24.2.29.16) re: expired.badssl.com & non-existing websites not loading a failed interstitial page.

Using the same STR/Cases mentioned above, ensured that the failed interstitial page was being displayed as per the following:

Example Example Example Example Example
IMG_0044 IMG_0045 IMG_0046 IMG_0047 IMG_0048

The above has also been verified via 1.62.2 as per brave/brave-ios#8789 (comment).

CCing @hffvld @Uni-verse

kjozwiak pushed a commit that referenced this pull request Mar 12, 2024
kjozwiak pushed a commit that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
4 participants