Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update [WIP/Pending] #2255

Closed
wants to merge 1 commit into from
Closed

Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update [WIP/Pending] #2255

wants to merge 1 commit into from

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 17, 2019 •
edited by tmancey
Loading

Uplift for #2232
fixes brave/brave-browser#3967
fixes: brave/brave-browser#4131

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR. I can confirm the errors are not related to any files which were changed for this PR
  • You have tested your change on Nightly.
  • The PR milestones match the branch they're landing to.

@ryanml
Merge pull request #2232 from /issues/3967
8c32507 
Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update
@ryanml ryanml added this to the 0.64.x - Dev milestone Apr 17, 2019
@ryanml ryanml requested review from tmancey and a team April 17, 2019 21:31
@ryanml ryanml self-assigned this Apr 17, 2019
@ryanml ryanml removed request for a team and tmancey April 17, 2019 21:32
@ryanml ryanml changed the title Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update [0.64] Fix Ads enabled for unsupported regions and enabled by default after 0.63.x update [WIP/Pending] Apr 17, 2019
@tmancey tmancey closed this Apr 17, 2019
@tmancey tmancey deleted the 2232-0.64 branch April 17, 2019 22:49
@tmancey tmancey removed this from the 0.64.x - Dev milestone Apr 17, 2019
@tmancey
Copy link
Collaborator

tmancey commented Apr 17, 2019

Closing as will open PRs once tested on nightly

@NejcZdovc NejcZdovc added this to the Closed milestone Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryanml ryanml

Labels
feature/ads feature/rewards
Projects
None yet
Milestone
Closed
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanml @tmancey @NejcZdovc