Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ads enabled when joining Rewards via panel #2266

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Fix Ads enabled when joining Rewards via panel #2266

merged 1 commit into from
Apr 18, 2019

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Apr 18, 2019

Fixes: brave/brave-browser#4156

Submitter Checklist:

Test Plan:

There are different testing permutations to ensure that Ads status is correct.
[@tmancey and myself ran through these and verified]

Fresh install is creating a profile with the version in this PR, Upgrade means upgrading from a version <0.62.x

Rewards never enabled

  1. PASSED
    Rewards enabled set to false
    Ads enabled set to false
    Upgrade

  2. PASSED
    Rewards enabled set to false
    Ads enabled set to false
    Fresh install

Via Rewards Panel

  1. IMPOSSIBLE SCENARIO
    Rewards enabled set to false
    Ads enabled set to true
    Upgrade

  2. PASSED
    Rewards enabled set to true
    Ads enabled set to false
    Upgrade

  3. IMPOSSIBLE SCENARIO
    Rewards enabled set to true
    Ads enabled set to true
    Upgrade

  4. IMPOSSIBLE SCENARIO
    Rewards enabled set to false
    Ads enabled set to true
    Fresh install

  5. IMPOSSIBLE SCENARIO
    Rewards enabled set to true
    Ads enabled set to false
    Fresh install

  6. PASSED
    Rewards enabled set to true
    Ads enabled set to true
    Fresh install

Via brave://rewards

  1. IMPOSSIBLE SCENARIO
    Rewards enabled set to false
    Ads enabled set to true
    Upgrade

  2. PASSED
    Rewards enabled set to true
    Ads enabled set to false
    Upgrade

  3. IMPOSSIBLE SCENARIO
    Rewards enabled set to true
    Ads enabled set to true
    Upgrade

  4. IMPOSSIBLE SCENARIO
    Rewards enabled set to false
    Ads enabled set to true
    Fresh install

  5. IMPOSSIBLE SCENARIO
    Rewards enabled set to true
    Ads enabled set to false
    Fresh install

  6. PASSED
    Rewards enabled set to true
    Ads enabled set to true
    Fresh install

Restart Browser

  1. PASSED
    Rewards enabled set to false
    Ads enabled set to false

  2. IMPOSSIBLE SCENARIO
    Rewards enabled set to false
    Ads enabled set to true

  3. PASSED
    Rewards enabled set to true
    Ads enabled set to false

  4. PASSED
    Rewards enabled set to true
    Ads enabled set to true

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@ryanml ryanml added this to the 0.65.x - Nightly milestone Apr 18, 2019
@ryanml ryanml requested a review from tmancey April 18, 2019 16:07
@ryanml ryanml self-assigned this Apr 18, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and worked with @ryanml to create the test plan to cover all permutations

@ryanml ryanml merged commit b8514ed into master Apr 18, 2019
@ryanml ryanml deleted the fix-4156 branch April 18, 2019 16:12
tmancey pushed a commit that referenced this pull request Apr 18, 2019
Fix Ads enabled when joining Rewards via panel
tmancey pushed a commit that referenced this pull request Apr 18, 2019
Fix Ads enabled when joining Rewards via panel
tmancey pushed a commit that referenced this pull request Apr 19, 2019
Fix Ads enabled when joining Rewards via panel
tmancey pushed a commit that referenced this pull request Apr 19, 2019
Fix Ads enabled when joining Rewards via panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ads not enabled by default when joining Rewards from panel
2 participants