Fix Ads enabled when joining Rewards via panel #2266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: brave/brave-browser#4156
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests && npm run test-security
) onnpm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
There are different testing permutations to ensure that Ads status is correct.
[@tmancey and myself ran through these and verified]
Fresh install
is creating a profile with the version in this PR,Upgrade
means upgrading from a version<0.62.x
Rewards never enabled
PASSED
Rewards enabled set to false
Ads enabled set to false
Upgrade
PASSED
Rewards enabled set to false
Ads enabled set to false
Fresh install
Via Rewards Panel
IMPOSSIBLE SCENARIO
Rewards enabled set to false
Ads enabled set to true
Upgrade
PASSED
Rewards enabled set to true
Ads enabled set to false
Upgrade
IMPOSSIBLE SCENARIO
Rewards enabled set to true
Ads enabled set to true
Upgrade
IMPOSSIBLE SCENARIO
Rewards enabled set to false
Ads enabled set to true
Fresh install
IMPOSSIBLE SCENARIO
Rewards enabled set to true
Ads enabled set to false
Fresh install
PASSED
Rewards enabled set to true
Ads enabled set to true
Fresh install
Via brave://rewards
IMPOSSIBLE SCENARIO
Rewards enabled set to false
Ads enabled set to true
Upgrade
PASSED
Rewards enabled set to true
Ads enabled set to false
Upgrade
IMPOSSIBLE SCENARIO
Rewards enabled set to true
Ads enabled set to true
Upgrade
IMPOSSIBLE SCENARIO
Rewards enabled set to false
Ads enabled set to true
Fresh install
IMPOSSIBLE SCENARIO
Rewards enabled set to true
Ads enabled set to false
Fresh install
PASSED
Rewards enabled set to true
Ads enabled set to true
Fresh install
Restart Browser
PASSED
Rewards enabled set to false
Ads enabled set to false
IMPOSSIBLE SCENARIO
Rewards enabled set to false
Ads enabled set to true
PASSED
Rewards enabled set to true
Ads enabled set to false
PASSED
Rewards enabled set to true
Ads enabled set to true
Reviewer Checklist:
After-merge Checklist:
changes has landed on.