Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes cache for publisher panel #2289

Merged
merged 1 commit into from
Apr 21, 2019
Merged

Fixes cache for publisher panel #2289

merged 1 commit into from
Apr 21, 2019

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Apr 19, 2019

Resolves brave/brave-browser#4143

Submitter Checklist:

Test Plan:

defined in the PR brave/brave-browser#4143 (comment)

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@kjozwiak
Copy link
Member

Both @LaurenWags and @srirambv have checked the above PR on Linux & macOS using 0.66.9 and confirmed that the original case mentioned in brave/brave-browser#4143 (comment) is working. I can't check Win right now as there's no Win executables for 0.66.9. It looks like 0.66.10 has just been spun up, so will double check once Win executables are uploaded for 0.66.10.

But looks like this working @rebron 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

media publisher info not shown in panel until you navigate away and come back
3 participants