Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pdfium #2342

Merged
merged 6 commits into from
May 31, 2019
Merged

Use pdfium #2342

merged 6 commits into from
May 31, 2019

Commits on May 30, 2019

  1. WIP - removal of pdf.js 

    Fixes brave/brave-browser#3846
Fixes brave/brave-browser#3694
Fixes brave/brave-browser#884
Fixes brave/brave-browser#3119
    @bsclifton @jumde
    bsclifton authored and jumde committed May 30, 2019
    Configuration menu
    Copy the full SHA
    2681798 View commit details
    Browse the repository at this point in the history

  2. Delete pdf.js related tests

    @simonhong @jumde
    simonhong authored and jumde committed May 30, 2019
    Configuration menu
    Copy the full SHA
    acd5006 View commit details
    Browse the repository at this point in the history

  3. Delete modifying navigator.plugins and mimeTypes 

    So far, brave only exposes flash when it is available.
Brave will use pdfium as a pdf viewer instead of pdf.js.
That causes plugins and mimeTypes will include pdf things.
That means we expose all that brave have.
So, we don't need to blacklist except flash plugins.
    @simonhong @jumde
    simonhong authored and jumde committed May 30, 2019
    Configuration menu
    Copy the full SHA
    7fea7a5 View commit details
    Browse the repository at this point in the history

  4. Update extension-whitelist checksum

    @simonhong @jumde
    simonhong authored and jumde committed May 30, 2019
    Configuration menu
    Copy the full SHA
    611d2f1 View commit details
    Browse the repository at this point in the history

  5. Rename pdf plugins name from chromium to chrome 

    Some google sites check pdf plugin name and do a different behavior whether
browser has chrome pdf plugin or not.
Ex, google docs print menu displays print preview when chrome pdf plugin is available.
Otherwise, just tries to download that documents as a pdf document.
    @simonhong @jumde
    simonhong authored and jumde committed May 30, 2019
    Configuration menu
    Copy the full SHA
    4d4f86a View commit details
    Browse the repository at this point in the history

  6. more rebase fallout

    @bsclifton @jumde
    bsclifton authored and jumde committed May 30, 2019
    Configuration menu
    Copy the full SHA
    ab13729 View commit details
    Browse the repository at this point in the history