Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transient tip overlay timeout #2539

Merged
merged 1 commit into from
Jun 4, 2019
Merged

Conversation

jdkuki
Copy link
Contributor

@jdkuki jdkuki commented May 29, 2019

Fixes brave/brave-browser#4590

Added property to overlay during creation to set timeout

Submitter Checklist:

Test Plan:

See steps at brave/brave-browser#4590

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jdkuki jdkuki requested a review from NejcZdovc May 29, 2019 23:30
@jdkuki jdkuki self-assigned this May 29, 2019
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone May 30, 2019
@jdkuki jdkuki force-pushed the transient-tip-overlay-timeout branch from 2018310 to 1e8490a Compare May 30, 2019 16:47
@jdkuki jdkuki force-pushed the transient-tip-overlay-timeout branch from 1e8490a to ae668c8 Compare May 30, 2019 19:46
@jdkuki jdkuki marked this pull request as ready for review May 30, 2019 19:48
@jdkuki jdkuki requested a review from ryanml June 4, 2019 16:25
@jdkuki jdkuki merged commit 1fa181c into master Jun 4, 2019
@ryanml ryanml deleted the transient-tip-overlay-timeout branch June 4, 2019 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thank you banner no longer auto dismisses after about 3 seconds
3 participants