Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined kTranslateUI symbol link error on windows release build #2557

Merged
merged 1 commit into from
May 31, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented May 31, 2019

Fix brave/brave-browser#4656

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@yrliou yrliou added this to the 0.68.x - Nightly milestone May 31, 2019
@yrliou yrliou self-assigned this May 31, 2019
@yrliou yrliou changed the title Fix undefined kTranslateUI symbol link error on windows Fix undefined kTranslateUI symbol link error on windows release build May 31, 2019
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passed

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@yrliou
Copy link
Member Author

yrliou commented May 31, 2019

lint failed on mac because of PR builder bug, it's not picking up my latest lint fix change, passed on all other platforms.
network-audit failed on mac because PR builder bug, it uses a wrong application name so can't find the application, passed on all other platforms.
Otherwise looking good, and I tested this do fix windows release build in release channel on local too, merging.

@yrliou yrliou merged commit dee7af4 into master May 31, 2019
@bsclifton bsclifton deleted the fix_translate_win_link_error branch May 31, 2019 06:35
yrliou added a commit that referenced this pull request May 31, 2019
Fix undefined kTranslateUI symbol link error on windows release build
yrliou added a commit that referenced this pull request May 31, 2019
Fix undefined kTranslateUI symbol link error on windows release build
yrliou added a commit that referenced this pull request May 31, 2019
Fix undefined kTranslateUI symbol link error on windows release build
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Upgrade from Chromium 71.0.3578.80 to 71.0.3578.98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined symbol link error for translate feature on windows release build
3 participants