Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cr130 follow up][Settings] Restores normal window search engine text. #26098

Merged
merged 1 commit into from
Oct 18, 2024
+5 −4
Merged

[cr130 follow up][Settings] Restores normal window search engine text. #26098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/brave_settings_strings.grdp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@
Automatically indexes websites that follow the OpenSearch spec.
</message>
<message name="IDS_SETTINGS_NORMAL_PROFILE_SEARCH_EXPLANATION" desc="Explanation for the search engine dropdown setting.">
Normal Window - Search engine used in the address bar
Normal Window - Search engine used in the address bar.
</message>
<message name="IDS_SETTINGS_PRIVATE_PROFILE_SEARCH_EXPLANATION" desc="Explanation for the search engine dropdown setting.">
Private Window - Search engine used in the address bar
Expand Down
7 changes: 4 additions & 3 deletions chromium_src/chrome/browser/ui/webui/settings/settings_localized_strings_provider.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@
// Override some chromium strings
#include "chrome/grit/branded_strings.h"
#include "chrome/grit/generated_resources.h"
#include "components/strings/grit/components_strings.h"

#undef IDS_SETTINGS_SEARCH_EXPLANATION
#define IDS_SETTINGS_SEARCH_EXPLANATION \
#undef IDS_SEARCH_ENGINE_CHOICE_SETTINGS_ENTRY_POINT_SUBTITLE
#define IDS_SEARCH_ENGINE_CHOICE_SETTINGS_ENTRY_POINT_SUBTITLE \
IDS_SETTINGS_NORMAL_PROFILE_SEARCH_EXPLANATION

#undef IDS_SETTINGS_CUSTOMIZE_PROFILE
Expand Down Expand Up @@ -76,4 +77,4 @@
#undef IDS_SETTINGS_SAFEBROWSING_STANDARD_BULLET_TWO
#undef IDS_SETTINGS_CUSTOMIZE_YOUR_CHROME_PROFILE
#undef IDS_SETTINGS_CUSTOMIZE_PROFILE
#undef IDS_SETTINGS_SEARCH_EXPLANATION
#undef IDS_SEARCH_ENGINE_CHOICE_SETTINGS_ENTRY_POINT_SUBTITLE
Loading