Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] SmartNTT Followup - 1.72.x #26100

Open
wants to merge 5 commits into
base: 1.72.x
Choose a base branch
from
Open

[ads] SmartNTT Followup - 1.72.x #26100

wants to merge 5 commits into from
+378 −49

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Oct 18, 2024

Uplift of #26021
Resolves brave/brave-browser#41648

Uplift of #26083
Resolves brave/brave-browser#41695

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey self-assigned this Oct 18, 2024
@tmancey tmancey requested a review from a team as a code owner October 18, 2024 16:45
@tmancey tmancey changed the title [ads] SmartNTT Uplift [ads] SmartNTT Followup - 1.72.x Oct 18, 2024
@aseren
[ads] Followup to "Smart NTT" #41303
0b4bbce 
# Conflicts:
#	components/brave_ads/browser/ads_service.h
#	components/brave_ads/browser/ads_service_mock.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tmancey tmancey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @aseren