Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix payment "receipts" cashed in between the 1st and 5th of the month do not appear in ad totals - 0.66.x #2741

Merged
merged 2 commits into from
Jun 25, 2019
Merged

Fix payment "receipts" cashed in between the 1st and 5th of the month do not appear in ad totals - 0.66.x #2741

merged 2 commits into from
Jun 25, 2019

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 19, 2019 •
edited
Loading

Fixes brave/brave-browser#4330
Uplift request from #2609
Requires #2740
Requires #2737

NOTE This PR was branched from #2740 so there are no conflicts. #2740 must be merged before this PR.

@tmancey tmancey added this to the 0.66.x - Beta milestone Jun 19, 2019
@tmancey tmancey requested a review from a team June 19, 2019 08:05
@tmancey tmancey self-assigned this Jun 19, 2019
@tmancey tmancey changed the title Fix payment "receipts" cashed in between the 1st and 5th of the month do not appear in ad totals Fix payment "receipts" cashed in between the 1st and 5th of the month do not appear in ad totals - 0.66.x Jun 19, 2019
@tmancey tmancey changed the title Fix payment "receipts" cashed in between the 1st and 5th of the month do not appear in ad totals - 0.66.x Fix payment "receipts" cashed in between the 1st and 5th of the month do not appear in ad totals - 0.66.x Beta Jun 19, 2019
@tmancey tmancey changed the title Fix payment "receipts" cashed in between the 1st and 5th of the month do not appear in ad totals - 0.66.x Beta Fix payment "receipts" cashed in between the 1st and 5th of the month do not appear in ad totals - 0.66.x Jun 21, 2019
@tmancey tmancey force-pushed the issues/4330-0.66.x branch 3 times, most recently from e2d592f to 9b7594b Compare June 25, 2019 00:39
@tmancey tmancey force-pushed the issues/4330-0.66.x branch 4 times, most recently from f160ade to 7d4f06e Compare June 25, 2019 02:36
@bsclifton
Copy link
Member

CI passed (although linting errors) on macOS and Linux. Replaying Win64 only here:
https://staging.ci.brave.com/job/brave-browser-build-pr/job/issues%252F4330-0.66.x/10/console

bsclifton
bsclifton approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, contingent on Windows passing (see link to Jenkins for console logs - will take a while to finish)

@tmancey tmancey merged commit 4f5de66 into 0.66.x Jun 25, 2019
@tmancey tmancey deleted the issues/4330-0.66.x branch June 25, 2019 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

Assignees

@tmancey tmancey

Labels
feature/ads feature/rewards
Projects
None yet
Milestone
0.66.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @bsclifton