Fix ads count isn't increasing for upgrade path #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emerick
reviewed
Jun 25, 2019
| @@ -14,4 +14,19 @@ uint64_t Time::NowInSeconds() { | |||
| return now.ToDoubleT(); | |||
| } | |||
|
|
|||
| uint64_t Time::MigrateToDoubleT(const uint64_t seconds) { | |||
| if (date_in_seconds < 10000000000) { | |||
There was a problem hiding this comment.
Maybe I'm missing it, but what is date_in_seconds? Do you mean seconds?
There was a problem hiding this comment.
Refactored to be more concise
vendor/bat-native-confirmations/src/bat/confirmations/internal/time.cc
Outdated
Show resolved
Hide resolved
tmancey
force-pushed
the
issues/5037
branch
3 times, most recently
from
b114a55
to
be50abb
Compare
tmancey
force-pushed
the
issues/5037
branch
2 times, most recently
from
908a053
to
7e3786e
Compare
This was referenced Jun 25, 2019
emerick
previously approved these changes
Jun 25, 2019
bbondy
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#5037
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Confirm after upgrade that legacy timestamps have been migrated by comparing
defaults/rewards_service/confirmations.jsonbefore and after the upgrade. Also confirm tokens are cashed out and ad notifications received show the correct amounts after an upgradeReviewer Checklist:
After-merge Checklist:
changes has landed on.