Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Widevine issue on macOS introduced with Chromium 76.0.3809.72 #3041

Merged
merged 1 commit into from
Jul 30, 2019

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Jul 30, 2019

Manually revert parts of https://chromium.googlesource.com/chromium/src/+/4aa3a22f4387

This option works great for Chrome because they bundle Widevine. Since we don't (we fetch using component updater), the TeamID doesn't match which causes the Library check to fail.

Above commit is part of the larger commit which was rolled up in:
https://chromium.googlesource.com/chromium/src/+/194826d6f8a3a0d932e18ed0f5452fd5c488e490%5E%21/#F29

Fixes brave/brave-browser#5433

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bsclifton bsclifton added this to the 0.70.x - Nightly milestone Jul 30, 2019
@bsclifton bsclifton requested a review from simonhong July 30, 2019 09:04
@bsclifton bsclifton requested a review from bridiver as a code owner July 30, 2019 09:04
@bsclifton bsclifton self-assigned this Jul 30, 2019
…rc/+/4aa3a22f4387

This option works great for Chrome because they bundle Widevine. Since we don't (we fetch using component updater), the TeamID doesn't match which causes the Library check to fail.

Above commit is part of the larger commit which was rolled up in:
https://chromium.googlesource.com/chromium/src/+/194826d6f8a3a0d932e18ed0f5452fd5c488e490%5E%21/#F29

Fixes brave/brave-browser#5433
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsclifton bsclifton merged commit 5d287d0 into master Jul 30, 2019
@bsclifton bsclifton deleted the bsc-fix-widevine branch July 30, 2019 09:09
@bsclifton
Copy link
Member Author

Merged because this was manually tested in 0.67.x (we reverted the change for app though, as it should not be needed). Because Nightly is broken at the moment, I used admin privs to force merge

bsclifton added a commit that referenced this pull request Jul 30, 2019
Fix Widevine issue on macOS introduced with Chromium 76.0.3809.72
bsclifton added a commit that referenced this pull request Jul 30, 2019
Fix Widevine issue on macOS introduced with Chromium 76.0.3809.72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Netflix doesn't work on clean profile - macOS only
2 participants