-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix widevine loading failure due to different TeamID #3061
Conversation
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
<plist version="1.0"> | ||
<dict> | ||
<key>com.apple.security.cs.disable-library-validation</key> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
helper-plugin-entitlements.plist
has one more property(allow-unsigned-executable-memory
).
Not sure helper
needs that also.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the comment here https://chromium.googlesource.com/chromium/src/+/3fa9da4e877a, com.apple.security.cs.allow-unsigned-executable-memory required to run Flash content and NaCl modules
. Not sure if widevine needs the same, but the approach with adding the other entitlement makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mkarolin Thanks for checking.
I think we don't need to add allow-unsigned-executable-memory
for helper
.
If this entitlement should be used for widevine, upstream also needs it.
9d92501
to
4467962
Compare
Set disable-library-validation entitlements for helper-app that loads widevine library.
4467962
to
8c8831e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ready for uplifts back to 0.68.x 😄 |
Set disable-library-validation entitlements for helper-app that
loads widevine library.
fix brave/brave-browser#5433
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.