Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provisioning profile and entitlement support on mac #319

Merged
merged 1 commit into from
Sep 5, 2018

Commits on Sep 5, 2018

  1. provisioning profile and entitlement support on mac

    Fix dev app id on mac
    
    To beable to support provisioning profiles the main app id needs to be
    set as org.brave.Brave.dev with all the other frameworks/helper apps
    falling directly under org.brave.Brave.<whatever>.
    
    Checked upstream canary builds and this is how it is done there as well.
    
    (cherry picked from commit 8146e3c)
    
    provisioning profile and entitlement support on mac
    
    This was added upstream which ended up breaking the the signing scripts
    and caused the osx build to not start.
    
    We might be ok reverting the changes if necessary like in
    faed762
    but i'd prefer to not worry about what that might break down the line.
    
    Upstream signing changes:
    https://chromium.googlesource.com/chromium/src.git/+/4d80b33e7c64069cb69041c4957ea77ecf6e14e8
    
    Original more descriptive but reverted commit:
    https://chromium.googlesource.com/chromium/src.git/+/b69d8c48da838196d9655402dd739e62227762a7
    
    (cherry picked from commit 43a9802)
    
    Use the correct path for mac provisioning profile
    
    (cherry picked from commit b344827)
    
    Update team_id for BRANDING.dev
    
    Update branding files to match dev
    
    This updates the branding files to match dev to support the recent
    provisoning and entitlement related changes.
    
    Update Apple app id's to use com.brave.Browser and add all profiles
    
    Needed because com.brave.Brave wasn't available for every release we
    needed.
    
    Update OSX signing requirements and BRANDING files
    
    Update mac app id in foundation_util.mm
    RyanJarv committed Sep 5, 2018
    Configuration menu
    Copy the full SHA
    1b2b1b6 View commit details
    Browse the repository at this point in the history