Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect users to extension store for inline install requests #338

Merged
merged 1 commit into from
Aug 20, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Aug 18, 2018

Fix brave/brave-browser#614

I tried to not have that patch but there was no way I could find around it.
Both the factory and the inline installer had multiple uses of the class to rename making it not possible to avoid the patch.

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@bbondy bbondy requested a review from darkdh August 18, 2018 03:50
@bbondy bbondy self-assigned this Aug 18, 2018
@bbondy bbondy merged commit 627920b into master Aug 20, 2018
@bbondy bbondy deleted the webstore-install branch August 21, 2018 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants