Hack wrapper to work around segfault #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmarier
force-pushed
the
francois-work-around-segfault-4142
branch
2 times, most recently
from
d1f697d
to
e10c75d
Compare
The `brave` binary returns a non-zero error code and that causes the wrapper to return a non-zero error code too. Since it's not possible to override the error code with an `exec` call (`exec` will terminate the shell immediately with a successful return value), we need to keep the original shell around so that we can hide the true return value of the `brave` binary. This hack should be removed once we have fixed the crash.
fmarier
force-pushed
the
francois-work-around-segfault-4142
branch
from
e10c75d
to
daa14f1
Compare
bridiver
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-around for brave/brave-browser#4142 until the underlying crash is fixed.
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
brave-browserpackage.brave-browserthe default browser (e.g.update-alternatives --config x-www-browseron Debian).xdg-open https://example.comand verify that it only opens one new tab and that it doesn't start another browser.Reviewer Checklist:
After-merge Checklist:
changes has landed on.