Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.71.x) #3693

Merged
merged 8 commits into from
Oct 15, 2019

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#6067
Related PR brave/brave-browser#6471

Uplift request from: #3653

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

bsclifton and others added 2 commits October 14, 2019 17:38
Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50
SaveCardBubbleControllerImpl::save_card_bubble_view() -> GetSaveCardBubbleView

Chromium change:

https://chromium.googlesource.com/chromium/src/+/565d2f77d08dfa1b2e8348a144c39e0412d1e502

commit 565d2f77d08dfa1b2e8348a144c39e0412d1e502
Author: siyua <[email protected]>
Date:   Wed Jul 31 18:15:35 2019 +0000

    [AF][Upstream Feedback] Stop SaveCardIconView from directly accessing
    controller Impl

    Also moved the controller interface to c/b/u/autofill/payments/

    This is a small refactoring being part of my loading bar animation CL.
    Extract it to a separate CL to unblock other CLs touching save card icon

    Bug: 964127
bsclifton and others added 5 commits October 14, 2019 18:18
Update l10n XTB and messages.json for 78.0.3904.50.
Re-enable BraveLayoutProvider for c78
Fixes Tor avatar menu after c78 bump.
@mkarolin mkarolin changed the title Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.71.x) WIP: Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.71.x) Oct 14, 2019
@mkarolin mkarolin marked this pull request as ready for review October 14, 2019 22:44
@NejcZdovc NejcZdovc removed their request for review October 15, 2019 04:51
@bsclifton bsclifton merged commit a4f2f6d into 0.71.x Oct 15, 2019
@bsclifton bsclifton deleted the 0.71.x-78.0.3904.50 branch October 15, 2019 20:58
@bsclifton bsclifton changed the title WIP: Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.71.x) Upgrade patches from Chromium 77.0.3865.90 to Chromium 78.0.3904.50 (0.71.x) Oct 15, 2019
fmarier pushed a commit that referenced this pull request Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants