-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote debugging can now be enabled via brave://settings/privacy #4044
Conversation
5ba9805
to
7470ad1
Compare
@rebron this section is getting a bit crowded- we have an opportunity to maybe have a Brave specific section... maybe something like If there was a new area, that would be where this setting, P3A, Push Messaging, WebRTC, and other coming soon settings (like disabling autocomplete, disabling tor) could live. Basically leaving the Chromium ones alone |
It would be good if settings change can be synced across multiple settings page. |
Let's go with |
Text updated, security review approved! 🎉 |
enabling remote debugging sends requests to google, are we okay not proxying those requests? |
@jumde since it's opt-in, this approach is OK and was security review approved. But I do think we can create an enhancement to proxy that in the future Also: there was a lint error (my bad) - just checked in a fix for that. Otherwise, all CI passed 🎉 |
@simonhong do you mean for the scenario where multiple windows with different profiles are open? (and setting is updated in one?) |
@bsclifton For this prefs, profiles are not important because it's local state. |
@simonhong ah- yes, I forgot you can manually open more instances of settings (if you keep trying via hamburger, it opens an already existing one) |
Yes, we can open many settings pages. but I think it is not the blocker for this PR :) |
6e16d6f
to
29979dc
Compare
Updated PR to cover the multiple window scenario (also, fixed this for P3A which was missing this too). Tested locally on macOS w/ Debug/Release. Rebased and CI running again. |
8f10390
to
e8305c9
Compare
e8305c9
to
846a1cf
Compare
Only failure was on iOS compilation (which was fixed/merged in master with #4070). I'll label accordingly, rebase, and restart CI |
Default for this is FALSE (meaning remote debugging is disabled). Setting is global (using local_state), not per-profile. Fixes brave/brave-browser#5640 Fixes brave/brave-browser#3199
…value is in sync For example, if you had two windows with brave://settings/privacy open
…its) Thanks to @simonhong for going through the docs w/ me to confirm life-cycle: https://chromium.googlesource.com/chromium/src.git/+/master/docs/webui_explainer.md
846a1cf
to
e7b2d99
Compare
There we go- after rebase, iOS looks good 🎉 |
Forgot to update documentation! Doing that now 😄 |
updated! |
Possibly also fixed brave/brave-browser#5618 when this landed |
Remote debugging can now be enabled via brave://settings/privacy
Remote debugging can now be enabled via brave://settings/privacy
Fixes brave/brave-browser#5640
Fixes brave/brave-browser#3199
NOTE: if this is merged, I will need to update https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Test remote debugging feature (brave/brave-browser#5640)
brave://inspect#devices
in Desktopinspect
under the device name in desktopRemote debugging
(it should have been turned off)inspect
under the device name in desktopTest Lighthouse (brave/brave-browser#3199)
Audits
Run audits
Remote debugging is DISABLED. If you want to use it, please enable in brave://settings/privacy
(may show 2 or 3 times)Remote debugging
(it should have been turned off)Audits
Run audits
Reviewer Checklist:
After-merge Checklist:
changes has landed on.