Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brave-ui dep to 7485c3c76bec747731c2085b6c5f97fcc62e1cc1 #4063

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

petemill
Copy link
Member

See diff at brave/brave-ui@9a6c7b4...7485c3c

Contains:

Required for brave/brave-browser#4262

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

@petemill
Copy link
Member Author

CI issue seems like a build script failure working out the installer name from the channel. Seems unrelated. Merging...

2:40:22  + '[' = release ']'
12:40:22  /Users/jenkins/jenkins/workspace/er-build-pr_brave-ui-update-7485@tmp/durable-c9365a93/script.sh: line 2: [: =: unary operator expected
12:40:22  ++ tr '[:lower:]' '[:upper:]'
12:40:22  + CHANNEL_CAPITALIZED=
12:40:22  + '[' = release ']'
12:40:22  /Users/jenkins/jenkins/workspace/er-build-pr_brave-ui-update-7485@tmp/durable-c9365a93/script.sh: line 3: [: =: unary operator expected
12:40:22  + BROWSER='Brave Browser '
12:40:22  + OUT_DIR=/Users/jenkins/jenkins/workspace/er-build-pr_brave-ui-update-7485/src/out/
12:40:22  + '[' = true ']'
12:40:22  /Users/jenkins/jenkins/workspace/er-build-pr_brave-ui-update-7485@tmp/durable-c9365a93/script.sh: line 5: [: =: unary operator expected
12:40:22  + open '/Users/jenkins/jenkins/workspace/er-build-pr_brave-ui-update-7485/src/out//Brave Browser .dmg'
12:40:22  The file /Users/jenkins/jenkins/workspace/er-build-pr_brave-ui-update-7485/src/out//Brave Browser .dmg does not exist.

@petemill petemill merged commit 45487f7 into master Nov 25, 2019
@petemill petemill deleted the brave-ui-update-7485 branch November 25, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants