Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly #4133

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

masparrow
Copy link
Contributor

@masparrow masparrow commented Dec 4, 2019

Fixes brave/brave-browser#7185

Submitter Checklist:

Test Plan:

As per brave/brave-browser#7185

Or;

  • Clean install Brave
  • Launch using command line '--rewards=reconcile-interval=3' to fast track AC's
  • Enable Rewards
  • Verify Uphold
  • Visit Verified Publisher(s)
  • Confirm sites in AC list
  • Wait for and then view the contribution notification

Screenshot 2019-12-04 at 15 31 24

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@masparrow masparrow added this to the 1.4.x - Nightly milestone Dec 4, 2019
@masparrow masparrow self-assigned this Dec 4, 2019
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@NejcZdovc NejcZdovc merged commit 470d7cd into master Dec 5, 2019
@NejcZdovc NejcZdovc deleted the issues/7185 branch December 5, 2019 08:35
@LaurenWags
Copy link
Member

Verified auto contribute notification shows accurate contribution amount using the following build:

Brave 1.4.60 Chromium: 79.0.3945.117 (Official Build) dev (64-bit)
Revision 04f0a055010adab4484f7497fbfdbf312c307f1d-refs/branch-heads/3945@{#1019}
OS macOS Version 10.14.6 (Build 18G103)

Steps used:

  1. Clean profile 1.4.60, launch with staging flags and short reconcile interval
  2. Enable rewards, claim UGP grant
  3. Set AC budget to 15 BAT
  4. Populate AC table with verified and non-verified sites
  5. Wait for AC to complete
  6. Confirm AC notification shows expected AC contribution amount, not 0.0

Screen Shot 2020-01-15 at 1 21 51 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Rewards notification not reflecting processed 'Auto Contribute' amount correctly
4 participants