Promotion claim date #4202
Merged
Promotion claim date #4202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmancey
requested changes
Dec 10, 2019
components/brave_rewards/browser/database/database_promotion.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/database/database_promotion.cc
Outdated
Show resolved
Hide resolved
components/brave_rewards/browser/database/publisher_info_database_unittest.cc
Show resolved
Hide resolved
NejcZdovc
force-pushed
the
promotion-claim-date
branch
from
35f9dd0
to
d720591
Compare
gdregalo
reviewed
Dec 10, 2019
| const char* column = "claimed_at"; | ||
| if (!db->DoesColumnExist(table_name_, column)) { | ||
| const std::string query = base::StringPrintf( | ||
| "ALTER TABLE %s ADD %s TIMESTAMP;", |
There was a problem hiding this comment.
do you need the semicolon in the end of sql statement?
There was a problem hiding this comment.
not needed, can remove
NejcZdovc
force-pushed
the
promotion-claim-date
branch
from
d720591
to
f122644
Compare
NejcZdovc
added
CI/skip-android
|
CI passed on all OS except on windows (build didn't start). Restarting windows |
gdregalo
approved these changes
Dec 11, 2019
bsclifton
added a commit
that referenced
this pull request
Jan 27, 2020
tmancey
pushed a commit
that referenced
this pull request
Jan 27, 2020
Promotion claim date # Conflicts: # components/brave_rewards/browser/database/publisher_info_database.cc # components/brave_rewards/browser/database/publisher_info_database.h # components/brave_rewards/browser/database/publisher_info_database_unittest.cc
hashmi-waseem
pushed a commit
to hashmi-waseem/brave-core
that referenced
this pull request
May 6, 2024
"Brave Ads has arrived!" notification should be shown on Linux after upgrade from 0.62.x - 0.64.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#7297
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
covered with unit tests
Reviewer Checklist:
After-merge Checklist:
changes has landed on.