Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve compatibility with MetaMask and allow web3 provider selection #4273

Merged
merged 1 commit into from
Jan 31, 2020
Merged

Improve compatibility with MetaMask and allow web3 provider selection #4273

merged 1 commit into from
Jan 31, 2020

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Dec 20, 2019 •
edited
Loading

Deprecate enabled setting in favour of lazy loading on demand if None is
set as the provider.

Fix brave/brave-browser#7503

See the spec in the issue for details of how this all works.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@bbondy bbondy added this to the 1.4.x - Nightly milestone Dec 20, 2019
@bbondy bbondy self-assigned this Dec 20, 2019
@NejcZdovc NejcZdovc removed this from the 1.4.x - Dev milestone Jan 3, 2020
@bbondy bbondy force-pushed the web3-providers branch 4 times, most recently from 947a528 to 719e2ab Compare January 21, 2020 20:15
@bbondy bbondy force-pushed the web3-providers branch 6 times, most recently from 56357f1 to d2ad4f5 Compare January 24, 2020 21:52
@bbondy bbondy marked this pull request as ready for review January 30, 2020 22:05
@bbondy bbondy requested a review from bridiver as a code owner January 30, 2020 22:05
@bbondy bbondy force-pushed the web3-providers branch 4 times, most recently from 85b33c6 to 1ec13cd Compare January 31, 2020 15:02
@bbondy bbondy requested review from emerick and ryanml January 31, 2020 16:05
emerick
emerick approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a couple of minor nits

browser/brave_wallet/brave_wallet_utils.cc Outdated Show resolved Hide resolved
browser/resources/settings/brave_default_extensions_page/brave_default_extensions_page.js Outdated Show resolved Hide resolved
...onents/brave_extension/extension/brave_extension/background/reducers/dappDetectionReducer.ts Outdated Show resolved Hide resolved
ryanml
ryanml approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great work

@bbondy bbondy merged commit 1fb4e66 into master Jan 31, 2020
@bbondy bbondy deleted the web3-providers branch January 31, 2020 19:11
@bbondy bbondy added this to the 1.5.x - Dev milestone Feb 4, 2020
@ryanml ryanml mentioned this pull request Feb 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerick emerick emerick approved these changes

@ryanml ryanml ryanml approved these changes

@bridiver bridiver Awaiting requested review from bridiver

Assignees

@bbondy bbondy

Labels
None yet
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging this pull request may close these issues.

Improve compatibility with MetaMask and allow web3 provider selection
4 participants
@bbondy @emerick @ryanml @NejcZdovc