-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes unable to get ad tokens if tokens are not ready #4334
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Unrelated CI issues |
Verification PASSED on
Ensured that
Ensured that
Triggered an ad on
Once an ad was viewed, ensured that an
Verification PASSED on
Tokens added:
Ad Notification viewed:
Refill attempted (not needed):
Tokens added:
Ad notification viewed:
Refill attempted (not needed):
|
Fixes brave/brave-browser#7666
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
Confirm ad tokens are successfully fetched in the console log and ads are viewed
Reviewer Checklist:
After-merge Checklist:
changes has landed on.