Upgrade from Chromium 80.0.3987.66 to Chromium 80.0.3987.78. #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type ANNOUNCEMENT has been added. Chromium change: commit 147807796e2bbd28853c41166a5611c2fd294d28 Author: Xing Liu <[email protected]> Date: Sat Jan 25 03:08:30 2020 +0000 Announcement notification for M80. This CL finishes the implementation of announcement notification. This feature targets M80. We show a notification on browser start up on Android and desktops for an important informational update. [email protected], [email protected], [email protected] Bug: 1042124
29 tasks
Build error on CI for Android: 20:26:04 In file included from ../../chrome/browser/updates/announcement_notification/announcement_notification_service.cc:17: 20:26:04 ../../brave/chromium_src/chrome/grit/generated_resources.h:9:10: fatal error: 'brave/grit/brave_generated_resources.h' file not found 20:26:04 #include "brave/grit/brave_generated_resources.h" 20:26:04 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 20:26:04 1 error generated. Looks like a Chromium bug. Chromium change is: https://chromium.googlesource.com/chromium/src/+/77c4d4c42f406fe1541fdd145b8201ab78ff9651 commit 77c4d4c42f406fe1541fdd145b8201ab78ff9651 Author: Xing Liu <[email protected]> Date: Tue Jan 28 03:58:56 2020 +0000 Announcement notification: Fix navigation to URL. Currently when clicking on the "Review" button, on Mac, it will always not navigate to the expected URL. On Debian, sometimes nothing happens. On Mac, if the notification has no origin, then click event will not be forwarded to NotificationHandler. This CL removes the origin check. Also changed the URL navigation API used to open the URL. Bug: 1042124 Specifically in chrome/browser/updates/announcement_notification/announcement_notification_service.cc: @@ -14,8 +14,10 @@ #include "chrome/browser/profiles/profile_attributes_storage.h" #include "chrome/browser/profiles/profile_manager.h" #include "chrome/browser/updates/announcement_notification/announcement_notification_metrics.h" +#include "chrome/grit/generated_resources.h" but the BUILD.gn file was not updated with the dependency on generated resources.
simonhong
approved these changes
Feb 3, 2020
|
|
||
| deps = [ | ||
| "//base", | ||
| + "//chrome/app:generated_resources", |
There was a problem hiding this comment.
Yes, this looks like upstream bug w/o this for android build.
I think their buildbot didn't see this error by luck? :)
|
CI only has |
|
Yes, the CI failure in |
mkarolin
added a commit
that referenced
this pull request
Feb 3, 2020
Upgrade from Chromium 80.0.3987.66 to Chromium 80.0.3987.78.
mkarolin
added a commit
that referenced
this pull request
Feb 3, 2020
Upgrade from Chromium 80.0.3987.66 to Chromium 80.0.3987.78.
|
FYI, filed an issue for above deps issue - https://bugs.chromium.org/p/chromium/issues/detail?id=1048346. |
|
FYI above deps issue was fixed in upstream - https://chromium-review.googlesource.com/c/chromium/src/+/2036915 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#7975
Related PR: brave/brave-browser#7979
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.