Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C80 followup: disables kVideoPlaybackQuality feature (1.5.x). #4501

Merged
merged 1 commit into from
Feb 5, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 4, 2020

Fixes brave/brave-browser#8029
Uplift from #4479

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@mkarolin mkarolin added this to the 1.5.x - Dev milestone Feb 4, 2020
@mkarolin mkarolin self-assigned this Feb 4, 2020
C80 followup: disables kVideoPlaybackQuality feature.
@mkarolin mkarolin force-pushed the maxk-disable-kVideoPlaybackQuality-1.5.x branch from a283aaf to 2647ba9 Compare February 5, 2020 03:22
@mkarolin mkarolin requested a review from a team February 5, 2020 08:12
@mkarolin
Copy link
Collaborator Author

mkarolin commented Feb 5, 2020

CI failures are known audit-network entries.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Everything passed other than audit-network on macOS and Linux as per #4501 (comment) which is a known issue not related to this specific PR.

Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 5ca9655 into 1.5.x Feb 5, 2020
@kjozwiak kjozwiak deleted the maxk-disable-kVideoPlaybackQuality-1.5.x branch February 5, 2020 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants