Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L10n for Chromium 80 from Transifex (1.4.x). #4516

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 5, 2020

Fixes brave/brave-browser#8031
Uplift from #4494

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

L10n for Chromium 80 from Transifex.
@mkarolin mkarolin added this to the 1.4.x - Beta milestone Feb 5, 2020
@mkarolin mkarolin self-assigned this Feb 5, 2020
@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 5, 2020
@mkarolin
Copy link
Collaborator Author

mkarolin commented Feb 6, 2020

CI failures are unrelated.

@mkarolin mkarolin removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 6, 2020
@mkarolin mkarolin requested a review from a team February 6, 2020 00:12
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2020

Going to restart Win x64 as the agent was removed as per the following:

17:52:45  Cannot contact i-03cf8d054c585875a: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
17:57:50  Could not connect to i-03cf8d054c585875a to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Feb 6, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2020

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.4.x approved after deliberating with @brave/uplift-approvers. As per #4516 (comment), audit-network failed on macOS, Linux and Win x64 and test-install on macOS which is a known issue and not related to this specific PR.

Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit 09a7001 into 1.4.x Feb 6, 2020
@kjozwiak kjozwiak deleted the maxk-c80l10n-1.4.x branch February 6, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants