Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes TOS links (uplift to 1.5.x) #4634

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Fixes TOS links (uplift to 1.5.x) #4634

merged 1 commit into from
Feb 14, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 13, 2020 •
edited by bsclifton
Loading

Uplift of #4625
Fixes brave/brave-browser#8229

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Feb 13, 2020
@brave-builds brave-builds added this to the 1.5.x - Dev milestone Feb 13, 2020
@NejcZdovc NejcZdovc removed their request for review February 13, 2020 19:50
@bsclifton bsclifton requested review from a team and removed request for bbondy, bsclifton, kjozwiak, rebron and srirambv February 13, 2020 22:20
kjozwiak
kjozwiak approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.5.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any issues/failures.

Please make sure that the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit ef3db58 into 1.5.x Feb 14, 2020
@kjozwiak kjozwiak deleted the pr4625_tos-link_1.5.x branch February 14, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.5.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases