Upgrade from Chromium 81 to Chromium 83 #5102

….4093.3. These patches required manual conflict resolution.

Used to be in FeatureUtilities, then the class was renamed to CachedFeatureFlags, then the method was moved to toolbar/bottom/BottomToolbarConfiguration.java Chromium changes: https://chromium.googlesource.com/chromium/src/+/732f05650ffbc5dd5ccff7e4b8a682804dab6d0b commit 732f05650ffbc5dd5ccff7e4b8a682804dab6d0b Author: Henrique Nakashima <[email protected]> Date: Tue Feb 4 23:42:54 2020 +0000 Rename FeatureUtilities to CachedFeatureFlags. FeatureUtilities is not accurate anymore, as this shouldn't contain code for specific features anymore, and it is (and has been) a stateful class. The responsibility of this class is to cache feature flags for use without native being loaded. This is CL 3/5 for renaming FeatureUtilities. Bug: 1012975 https://chromium.googlesource.com/chromium/src/+/12f84491145a1cab6aad9f001f64e6f73d40cd27 commit 12f84491145a1cab6aad9f001f64e6f73d40cd27 Author: Henrique Nakashima <[email protected]> Date: Wed Feb 26 22:45:15 2020 +0000 Move TabUI/Duet feature-specific methods out of CachedFeatureFlags. CachedFeatureFlags should only have generic methods. Bug: 1012975

Chromium change: https://chromium.googlesource.com/chromium/src/+/9b75f752e2c060c7b3cf1ecd4d21cfdabf89a522 commit 9b75f752e2c060c7b3cf1ecd4d21cfdabf89a522 Author: Natalie Chouinard <[email protected]> Date: Wed Mar 11 20:55:02 2020 +0000 [Settings Refactor] Move About Chrome Settings Move About Chrome Settings to org.chromium.chrome.browser.about_settings package. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/e64d53eeb6130c5eac8c755b6ced4a60a30cbc20 commit e64d53eeb6130c5eac8c755b6ced4a60a30cbc20 Author: Natalie Chouinard <[email protected]> Date: Thu Mar 12 01:48:28 2020 +0000 [Settings Refactor] Move Accessibility settings Move Accessibility settings to org.chromium.chrome.browser.accessibility.settings and update OWNERS. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/5d85a5c5ce0c4ae8fdd41addf16176652147a7d8 commit 5d85a5c5ce0c4ae8fdd41addf16176652147a7d8 Author: Natalie Chouinard <[email protected]> Date: Thu Feb 6 20:32:58 2020 +0000 Reland "[Settings Refactor] Move autofill settings" This is a reland of 359bdf7656ebcda379e42d1ce72ee897d36c5286 Proguard rules now extended to ensure Fragments aren't removed in release: https://crrev.com/c/2036872. There is no change to this patch from the original. Original change's description: > [Settings Refactor] Move autofill settings > > Move autofill settings alongside autofill code. > > Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/cdf105b25a5f2cc90645830633ce4f1d175a2c76 commit cdf105b25a5f2cc90645830633ce4f1d175a2c76 Author: Natalie Chouinard <[email protected]> Date: Tue Feb 4 20:38:18 2020 +0000 [Settings Refactor] Move datareduction settings Move datareduction settings alongside other datareduction code. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/e29477adc01dd1f7ffc9b05b48bc250e3d318651 commit e29477adc01dd1f7ffc9b05b48bc250e3d318651 Author: Natalie Chouinard <[email protected]> Date: Wed Feb 5 23:31:52 2020 +0000 [Settings Refactor] Move Developer settings Move Developer Settings alongside other tracing code. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/332deb89881bb5ac213aa0437c0da77e7979b33b commit 332deb89881bb5ac213aa0437c0da77e7979b33b Author: Natalie Chouinard <[email protected]> Date: Wed Mar 11 23:47:26 2020 +0000 [Settings Refactor] Move Download settings Move Download settings to org.chromium.chrome.browser.download package. This package rename will be followed by modularization (crbug.com/1047896). Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/3923b9b7c936c33579c47183989fccebf9e255df commit 3923b9b7c936c33579c47183989fccebf9e255df Author: Natalie Chouinard <[email protected]> Date: Wed Mar 4 17:41:48 2020 +0000 [Settings Refactor] Move Language settings Move Language settings to org.chromium.chrome.browser.language package and add Language OWNERS. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/e1eda2a9ab1fd4f89fbd869cd306b76a19f21a7c commit e1eda2a9ab1fd4f89fbd869cd306b76a19f21a7c Author: Natalie Chouinard <[email protected]> Date: Wed Feb 26 18:54:51 2020 +0000 [Settings Refactor] Move Notification settings Move Notification settings alongside Notification code. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/4709a83c783f79f5924857792f2146a623e70b78 commit 4709a83c783f79f5924857792f2146a623e70b78 Author: Natalie Chouinard <[email protected]> Date: Thu Mar 12 20:44:14 2020 +0000 [Settings Refactor] Move Password settings Move Password settings to password_manager package. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/0a54e8bc03cb49ce55615a9083faca236a8f19a1 commit 0a54e8bc03cb49ce55615a9083faca236a8f19a1 Author: Natalie Chouinard <[email protected]> Date: Fri Mar 6 00:41:06 2020 +0000 [Settings Refactor][TTS] Move Contextual Search settings Move Contextual Search settings alongside Contextual Search code. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/a764638b06aaa69d60a43c3ceaecd0f4ce2792e8 commit a764638b06aaa69d60a43c3ceaecd0f4ce2792e8 Author: Natalie Chouinard <[email protected]> Date: Wed Mar 11 23:53:23 2020 +0000 [Settings Refactor] Move Privacy settings Move remaining privacy settings screens classes to org.chromium.chrome.browser.privacy.settings package and update OWNERS. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/2b3d19ca614346bef9df498c48c2ddf1d6173026 commit 2b3d19ca614346bef9df498c48c2ddf1d6173026 Author: Natalie Chouinard <[email protected]> Date: Thu Mar 5 00:46:11 2020 +0000 [Settings Refactor] Move Browsing Data settings Move Clear Browsing Data settings alongside other Browsing Data code, and update associated OWNERS files. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/15e7285d53774f7ea0dc425f778b688544f6034a commit 15e7285d53774f7ea0dc425f778b688544f6034a Author: Natalie Chouinard <[email protected]> Date: Thu Feb 6 19:20:30 2020 +0000 [Settings Refactor] Move Sync settings Move Sync settings alongside Sync code. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/bb5aabdc4715d8bc8f0b80be1becc8fc85ff3f0a commit bb5aabdc4715d8bc8f0b80be1becc8fc85ff3f0a Author: Natalie Chouinard <[email protected]> Date: Wed Feb 5 19:19:35 2020 +0000 [Settings Refactor] Move Theme settings Move Theme settings alongside other night_mode code. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/ee3a8d8aeec2473b93618a7fee770b7f3e7a831e commit ee3a8d8aeec2473b93618a7fee770b7f3e7a831e Author: Natalie Chouinard <[email protected]> Date: Tue Mar 10 21:37:41 2020 +0000 [Settings Refactor] Move Site Settings Move Site Settings to org.chromium.chrome.browser.site_settings package and update OWNERS. Bug: 1047357

Chromium change: https://chromium.googlesource.com/chromium/src/+/6b73c7497419485f3c9c01a620a8ad9c3621b60d commit 6b73c7497419485f3c9c01a620a8ad9c3621b60d Author: Clark DuVall <[email protected]> Date: Wed Mar 11 19:00:15 2020 +0000 Move PermissionManager to //components/permissions The PermissionManagerFactory is kept in //chrome, and an equivalent will be added in //weblayer to initialize permission contexts. The map of permission contexts are now injected into the constructor of PermissionManager. Some unit tests were kept in //chrome which relate to chrome-specific logic in GetCanonicalOrigin(). Bug: 1025609

Chromium change: https://chromium.googlesource.com/chromium/src/+/217fad8a27109428a373d61dac32e316e41c0e21 commit 217fad8a27109428a373d61dac32e316e41c0e21 Author: Clark DuVall <[email protected]> Date: Wed Feb 19 19:58:00 2020 +0000 Move PermissionRequestImpl to //components/permissions This required moving all the strings and icons that are referenced in PermissionRequestImpl as well. kProductIcon which is used for the PROTECTED_MEDIA_IDENTIFIER on ChromeOS was left in //chrome since kProductIcon is different depending on chrome branding. The IDR_* resources used on Android were moved in a way that still works with chrome's ResourceMapper. WebLayer will need a similar system to map the native IDR_* constants to Android drawable resources. Bug: 1025609

Chromium change: https://chromium.googlesource.com/chromium/src/+/38189ee95375d6692a8fdb43f349a6ce4cd764f6 commit 38189ee95375d6692a8fdb43f349a6ce4cd764f6 Author: Clark DuVall <[email protected]> Date: Fri Feb 14 02:30:28 2020 +0000 Move PermissionUmaUtil to //components/permissions This also introduces PermissionsClient, which allows code in //components/permissions to call embedder specific logic. Bug: 1025609

TODO:check if we need to patch the "new infrastructure" (fcm_invalidation). Chromium change: https://chromium.googlesource.com/chromium/src/+/881c881bde8acc9d507db7bf3157b18a2790d9ef commit 881c881bde8acc9d507db7bf3157b18a2790d9ef Author: Marc Treib <[email protected]> Date: Wed Feb 12 19:12:45 2020 +0000 Cleanup: Delete legacy (Tango) invalidations code All invalidations clients have migrated to the new infrastructure, so the old implementation is now unused and can be cleaned up. This CL deletes *most* of the code. Still left to be done: - DeprecatedInvalidatorRegistrar is still used by some tests (via FakeInvalidationService), which should be migrated off. - InvalidationServiceAndroid and the corresponding Java code is still around. This reduces Android binary size by about 4kB: Normalized APK Size: -4184 bytes Bug: 1029481

Chromium change: https://chromium.googlesource.com/chromium/src/+/d2013f9668d0587b1042572dadc6bd2e772d3248 commit d2013f9668d0587b1042572dadc6bd2e772d3248 Author: Nicolas Arciniega <[email protected]> Date: Fri Feb 7 23:00:56 2020 +0000 Rename ProxyResolutionService to ConfiguredProxyResolutionService This change is the first step in creating a proxy resolver that completely relies on the underlying system to figure out a proxy. The ProxyResolutionService is currently deeply tied to the notion of first fetching proxy configurations (ex: a PAC URL) and then using those configurations to resolve a proxy. Since a proxy resolver that truly defers to the underlying operating system for all proxy logic does not follow this model, it is helpful if we separate the generic ProxyResolutionService from the notion of configurations. This change renames the existing ProxyResolutionService, which relies on fetching proxy configurations, to ConfiguredProxyResolutionService. The only other changes to this file are suggestions from presubmit and Tricium. A set of future CLs will break up the ConfiguredProxyResolutionService into the logical pieces needed to create a new, generic ProxyResolutionService that does not necessarily depend on configs. This change is intended to introduce zero functional changes. It is a pure refactor change. Bug: 1032820

Upstream has added the same functionality as what we patched in. Chromium change: https://chromium.googlesource.com/chromium/src/+/9b743d81599bec7fddcb6ec4a633427b63474616 commit 9b743d81599bec7fddcb6ec4a633427b63474616 Author: Nate Fischer <[email protected]> Date: Tue Feb 4 22:58:49 2020 +0000 AW: expose chrome_public_manifest_package as GN arg No change to logic. This exposes chrome_public_manifest_package as a GN arg to support WebView developers who wish to compile monochrome_public_apk. This updates WebView docs to mention the new GN arg. Bug: 1048327

Likely needs to be fixed by Android team. Chromium change: https://chromium.googlesource.com/chromium/src/+/ef0081508870bc77b5daedbd7adc863f8ebfdb9c commit ef0081508870bc77b5daedbd7adc863f8ebfdb9c Author: Patrick Noland <[email protected]> Date: Fri Jan 31 02:58:55 2020 +0000 [ToolbarMVC] Move BottomToolbar listeners to toolbar/bottom Bug: 865801

Chromium change: https://chromium.googlesource.com/chromium/src/+/da6aa73fd5178488363fcde841a0b4405eefccb6 commit da6aa73fd5178488363fcde841a0b4405eefccb6 Author: Matt Falkenhagen <[email protected]> Date: Thu Mar 12 02:24:43 2020 +0000 Remove link to Advanced Font Settings extension. This extension is owned by my personal chromium account and I'm not able to maintain it officially.

Chromium change: https://chromium.googlesource.com/chromium/src/+/f5919f942495f649b152b1aa501022f4210d5a29 commit f5919f942495f649b152b1aa501022f4210d5a29 Author: Demetrios Papadopoulos <[email protected]> Date: Wed Feb 19 06:29:20 2020 +0000 Settings: Refactor site-settings-page to use a dom-repeat. This CL removes a lot of redundancy from site_settings_page.js both in HTML and in JS. Specifically: 1) Using dom-repeat eliminates redundant HTML code 2) The introduction of the |categoryList| makes populating the |focusConfig| trivial 3) Fetching default values for each permission category type also becomes simpler. Moreover the programmatic approach is more flexible and should make the upcoming "Friendly Privacy Settings" changes easier to implement, by allowing splitting the permissions list in two parts programmatically in JS (no more redundant dom-if expressions). Bug: 1032584

Chromium change: https://chromium.googlesource.com/chromium/src/+/86dea68fc642a5deb1a3398afd212de76b1652a8 commit 86dea68fc642a5deb1a3398afd212de76b1652a8 Author: Joshua Pawlicki <[email protected]> Date: Fri Jan 31 17:55:05 2020 +0000 Refactor chrome/installer/mac/signing in preparation for updater reuse. The main thing here is to move get_parts into the parts.py. Bug: 926234

Chromium change: https://chromium.googlesource.com/chromium/src/+/37109f21fbbeece29c5eb75f5a3ac3f0caa7a20a commit 37109f21fbbeece29c5eb75f5a3ac3f0caa7a20a Author: jessing <[email protected]> Date: Mon Feb 3 01:59:20 2020 +0000 [system-web-apps] Add ability to grant requestable schemes in a WebUI Currently chrome:// URLs are not allowed to embed chrome-untrusted:// URLs because we never grant request access to chrome-untrusted:// URLs. To allow for this, this CL makes a couple of changes (Note that this is only fixes the issue on the browser side. The renderer still has some checks that stop us from loading chrome-untrusted:// iframes.): 1. Make the set of requestable schemes part of content::WebUI. This way clients of WebUI can control which additional schemes they want their WebUI to be able to request. The function to add a scheme is added as a webUI API because it is expected to be used by chrome/ WebUIControllers that use chrome-untrusted://. 2. When creating a WebUI in RenderFrameHostImpl::CreateWebUI(), grant request access to the schemes the WebUI specified. 3. Decouple granting access to chrome:// and file:// from ChildProcessSecurityPolicy::GrantWebUIBindings(). Instead add this to the list of schemes in content::WebUIImpl. Long term, we should be able to remove these schemes from content::WebUIImpl and instead have each client specify the schemes they want access to, similarly to how clients will call EnableMojoJsBindings()[1]. [1] https://cs.chromium.org/chromium/src/content/browser/process_internals/process_internals_ui.cc?l=53&rcl=0ab24b983b19f971f40b2f1e3f5a5b95c7a1ad9a Bug: 1043548

These were upstream patches applied in Chromium 81 to fix Linux build issue. They are included in Chromium 83. See cd0ec9e and 641ec7b

Chromium change: https://chromium.googlesource.com/chromium/src/+/25555374c31b247963cdb9e3c7f8444a6148742d commit 25555374c31b247963cdb9e3c7f8444a6148742d Author: Daniel Cheng <[email protected]> Date: Fri Feb 7 20:46:25 2020 +0000 Document how to add new IDL files for modules. Fixes: 1048907

The same functionality was added upstream. Chromium change: https://chromium.googlesource.com/chromium/src/+/17ea57e50eafaa4d737d97806e96466a7e4126b9 commit 17ea57e50eafaa4d737d97806e96466a7e4126b9 Author: Xing Liu <[email protected]> Date: Tue Feb 4 18:52:31 2020 +0000 Announcement notification: Add missing deps. This CL adds a few missing deps for announcement notification system. Currently there is no build failure. Check command: gn check out/Debug //chrome/browser/updates/announcement_notification Refactor that requires large code change needs to be merged after M81. Bug: 1048346

Chromium change: https://chromium.googlesource.com/devtools/devtools-frontend/+/e4a10affd8fb231dba2500aad1165304ade291df commit e4a10affd8fb231dba2500aad1165304ade291df Author: Tim van der Lippe <[email protected]> Date: Mon Mar 16 10:53:20 2020 +0000 Extract tsconfig.base.json to obtain VSCode compatible tsconfig.json VS Code requires all files including .d.ts files to be included in order to correctly resolve their definitions. However, we can't add the include and exclude keywords to the tsconfig.json, as that would break inheriting tsconfig.json configurations. Therefore, extract a tsconfig.base.json with the original configuration and let tsconfig.json extend it. This should instruct VS Code to use the tsconfig, which includes all files, while all other infrastructure can remain working as-is. Fixed: 1056211

…4100.3.

Chromium change: https://chromium.googlesource.com/chromium/src/+/b6762167670454d9b44a0ad80c3a55ac4f227180 commit b6762167670454d9b44a0ad80c3a55ac4f227180 Author: Mugdha Lakhani <[email protected]> Date: Mon Mar 30 10:23:25 2020 +0000 [WebLayer] Move PageInfo and PageInfoUI to components. PageInfo and PageInfoUI have already been refactored into parts that can be shared among embedders, and chrome-specific parts. This CL simply moves the former to components. In addition, this moves some vector icons to components,and creates a a new build target in components/resources to house all resources for components resources that are mapped to an Android resource. Permissions code is updated to depend on this new target. Bug: 1052375

Chromium change: https://chromium.googlesource.com/chromium/src/+/92f84b6ac7af44269fa377f4ecc1eaf05e83c1e5 commit 92f84b6ac7af44269fa377f4ecc1eaf05e83c1e5 Author: Rohit Rao <[email protected]> Date: Wed Mar 25 14:57:50 2020 +0000 Moves //components/crash/content/app to //components/crash/core/app. Most of the files in this directory had no //content dependencies. Those that did were left in place. BUG=1061431

Chromium change: https://chromium.googlesource.com/chromium/src/+/754e9e09910ebe1ec39c262d1fb22119d30d955e commit 754e9e09910ebe1ec39c262d1fb22119d30d955e Author: Robbie McElrath <[email protected]> Date: Mon Mar 30 19:00:18 2020 +0000 [WebLayer] Create a SiteSettingsClient interface. This interface is used by the Site Settings UI to get embedder-specific logic, and will be used to abstract Chrome-specific logic so the rest of the Site Settings UI can be componentized. The Client is set in the Fragment by SettingsActivity. As of this CL, only the ManagedPreferenceDelegate is accessible through this new interface, but other embedder-specific logic will be moved behind it as well in future CLs. See go/weblayer-site-settings for more information. Bug: 1058597

Moved call to create Brave config into config_factory.py. Added a static method to our config creation to prevent an exception when Chrome's config loading is attempted. Maybe need to add code to throw an exception when provisioning profile is not found from the env when not a development config, but development var isn't passed into the config_factory which means we'd need to add another patch. Chromium change: https://chromium.googlesource.com/chromium/src/+/f21027ab4d74ea035d98bbf6ba77e8fa148f08b5 commit f21027ab4d74ea035d98bbf6ba77e8fa148f08b5 Author: Joshua Pawlicki <[email protected]> Date: Mon Mar 23 17:45:15 2020 +0000 Create an updater-specific signing pipeline. Bug: 926234

Chromium change: https://chromium.googlesource.com/chromium/src/+/6ade5dc4cb183b0f58cf9c1795fdfc6cba5e14bf commit 6ade5dc4cb183b0f58cf9c1795fdfc6cba5e14bf Author: Andrew Grieve <[email protected]> Date: Tue Mar 17 20:52:02 2020 +0000 Rename source_is_generated -> enable_input_discovery_for_gn_analyze And update docs for the setting. Bug: 1054892

We patch code in places by immediately returning from functions/methods, which causes ureachable-code errors. Chromium changes: 3afe3d815b02 Enable -Wunreachable-code for internal iOS builds. 16249b38f48a Reland "Enable -Wunreachable-code in iOS builds (except for internal builds)." 18926aac4b17 Revert "Enable -Wunreachable-code in iOS builds (except for internal builds)." a7b569e6be6a Enable -Wunreachable-code in iOS builds (except for internal builds). 1add1c909d19 Enable -Wunreachable-code in Mac builds. eb5502886733 Wunreachable-code: List target_os that do not use the flag, instead of the ones that do. e44258cbf461 Enable -Wunreachable-code for win/asan. fa18fef1b31a Reland "Enable -Wunreachable-code on Windows." 6d6956573c0e Revert "Enable -Wunreachable-code on Windows." e334b16ecf68 Enable -Wunreachable-code on Windows. 8a3cdc59b72d Reland "Enable -Wunreachable-code on Android." eea1e99dfa7e Revert "Enable -Wunreachable-code on Android." 4a5118005a89 Enable -Wunreachable-code on Android. 72f3015c3b88 Reland "Enable -Wunreachable-code in Chrome OS builds." 451c0a00e417 Revert "Enable -Wunreachable-code in (non-arm) Chrome OS builds." 2ff5fdbc7071 Enable -Wunreachable-code in (non-arm) Chrome OS builds. 057808f1be13 Reland "Enable -Wunreachable-code in Fuchsia builds." 66d981c07546 Revert "Enable -Wunreachable-code in Fuchsia builds." ec7d2855c15a Enable -Wunreachable-code in Fuchsia builds. d9d917c05c2a Enable Wunreachable-code for chromium_code on Linux.

Use constructors instead. Chromium change: https://chromium.googlesource.com/chromium/src/+/b0065070fe6ae7e9a1730b7552c8ea6a952bcdc0 commit b0065070fe6ae7e9a1730b7552c8ea6a952bcdc0 Author: Peter Kasting <[email protected]> Date: Tue Feb 4 20:19:40 2020 +0000 Eliminate FlexSpecification private constructor. Having the various WithXXX() methods depending on this was fragile against future changes that add members to the class, unless the constructor takes them as args. This bit me while fixing bug 1012136. They now do a copy-and-set (preserving all existing state). Having the ForXXX() methods depend on this failed to take advantage of member default values, and delegating constructors, which is also a bit of a maintenance hazard. These are now constructors directly. Finally, having factory functions is unusual when construction cannot fail, needs no extra initialization, and doesn't return a pointer to a polymorphic base; plus, the factory methods are more verbose, but (IMO) do not really add significant/necessary clarity. Bug: none

Chromium change: https://chromium.googlesource.com/chromium/src/+/ee5af39bb4f01da6c7c0b803af74a9361e6fd8c6 commit ee5af39bb4f01da6c7c0b803af74a9361e6fd8c6 Author: Minggang Wang <[email protected]> Date: Wed Feb 5 02:55:28 2020 +0000 [OnionSoup] Move resource_load_info.mojom into Blink The current mojom struct ResourceLoadInfo defined in //content is used to notify the status of a resource loading, which is unavailable inside Blink. Along with the implementation of OnionSoup of loaders, we are going to notify the loading status from Blink directly. So we have to move this mojom struct into Blink in order to leverage it there. This CL makes the changes below: - Remove the ResourceType in //content and its typemap and replace with the mojom one. - Move the resource_load_info.mojom into Blink. Bug: 860403

Chromium change: https://chromium.googlesource.com/chromium/src/+/09192197b406ef2f33b6b425a1355c64c25b34a4 commit 09192197b406ef2f33b6b425a1355c64c25b34a4 Author: Rushan Suleymanov <[email protected]> Date: Thu Mar 12 23:00:59 2020 +0000 [Sync] Rename title field for bookmarks This patch is first in a series of changes. Legacy title field in BookmarkSpecifics renamed without any changes in behaviour. Bug: 1058376

Chromium change: https://chromium.googlesource.com/chromium/src/+/2e98db0e52f3f55056783031ab9f7377d4a12ad5 commit 2e98db0e52f3f55056783031ab9f7377d4a12ad5 Author: Alison Maher <[email protected]> Date: Fri Mar 27 03:12:12 2020 +0000 Add histograms for all Windows high contrast themes An existing histogram, Accessibility.InvertedColors, tracks whether the dark-on-light Windows high contrast theme is enabled. This change adds an enumerated histogram for all Windows high contrast themes and deprecates Accessibility.InvertedColors. Bug: 970285

Chromium changes make is easier to override the whole file rather than patch each BUILDFLAG(USE_GOOGLE_UPDATE_INTEGRATION) location. Chromium change: https://chromium.googlesource.com/chromium/src/+/f2c32196752a7e8a7b32c358c8529784b3f33c53 commit f2c32196752a7e8a7b32c358c8529784b3f33c53 Author: Nico Weber <[email protected]> Date: Thu Mar 26 15:06:15 2020 +0000 win: Convert kUseGoogleUpdateIntegration to a buildflag. - Suppresses several -Wunreachable-code warnings - Makes it clearer this is a build-time constant - Removes half a use of GOOGLE_CHROME_BUILD in a .h file No intended behavior change. Bug: 346399,961769

Renamed to ExecutionContextLifecycleObserver. Also, reorganized the ovrride file to match the order of methods in the original Chromium source. Chromium changes: https://chromium.googlesource.com/chromium/src/+/539e6b94b4f95c1710718085c0e526a69611b2bd commit 539e6b94b4f95c1710718085c0e526a69611b2bd Author: Keishi Hattori <[email protected]> Date: Mon Feb 17 08:44:48 2020 +0000 Rename ContextLifecycleObserver to ExecutionContextLifecycleObserver Rename ContextLifecycleObserver to ExecutionContextLifecycleObserver in anticipation of introducing a base class to platform/ in crrev.com/c/2046626 Bug: 1052738 ContextDestroyed method signature change: https://chromium.googlesource.com/chromium/src/+/b0a2875270b3a5ff644378e9a26f12cbdabae0e8 commit b0a2875270b3a5ff644378e9a26f12cbdabae0e8 Author: Keishi Hattori <[email protected]> Date: Sun Feb 16 19:42:37 2020 +0000 Use HeapObserverList for ContextLifecycleObserver Use the HeapObserverList that was added in crrev.com/c/2054687 for ContextLifecycleObserver. Bug: 1052319 C'tor signature change: https://chromium.googlesource.com/chromium/src/+/0177ea4ac533757e1d530458bf69fb5daf5557c0 commit 0177ea4ac533757e1d530458bf69fb5daf5557c0 Author: Nate Chapin <[email protected]> Date: Fri Feb 7 16:58:14 2020 +0000 Make ExecutionContext a private parent class of Document This is a step in preparation for moving the ExecutionContext from Document to LocalDOMWindow. Using virtual inheritance, this CL leaves several ExecutionContext subclasses (UseCounter, ConsoleLogger, and FeaturePolicyParserDelegate) as public parent classes of Document, while making ExecutionContext private. This exposes all of the places that depend directly on Document being an ExecutionContext, while leaving the long tail of indirect dependencies in place temporarily. Downcasts (most using To<Document>, a few using static_cast) have been converted to use a set of new, temporary static Document::From and Document::DynamicFrom methods. These behave very similarly to To<> and DynamicTo<>, respectively. This is necessary because To<> and DynamicTo<> no longer have the needed visibility of the inheritance relationship between Document and ExecutionContext to be allowed to perform the cast. Added a new Document::ToExecutionContext() helper, and changed implicit upcasts to use that explicitly. This intentionally does not use the existing GetExecutionContext() that Document inherits from Node. ToExecutionContext() should be temporary, and and all ToExecutionContext() will be audited to determine whether they should use GetExecutionContext() or follow a different path to the LocalDOMWindow. Callers of functions that Document inherited from ExecutionContext were handled case by case. For cases where many callers were using the inherited function, I've added a helper on Document. For other cases, the call now requires a Document::ToExecutionContext(). Bug: 1029822

Chromium change: https://chromium.googlesource.com/chromium/src/+/0177ea4ac533757e1d530458bf69fb5daf5557c0 commit 0177ea4ac533757e1d530458bf69fb5daf5557c0 Author: Nate Chapin <[email protected]> Date: Fri Feb 7 16:58:14 2020 +0000 Make ExecutionContext a private parent class of Document This is a step in preparation for moving the ExecutionContext from Document to LocalDOMWindow. Using virtual inheritance, this CL leaves several ExecutionContext subclasses (UseCounter, ConsoleLogger, and FeaturePolicyParserDelegate) as public parent classes of Document, while making ExecutionContext private. This exposes all of the places that depend directly on Document being an ExecutionContext, while leaving the long tail of indirect dependencies in place temporarily. Downcasts (most using To<Document>, a few using static_cast) have been converted to use a set of new, temporary static Document::From and Document::DynamicFrom methods. These behave very similarly to To<> and DynamicTo<>, respectively. This is necessary because To<> and DynamicTo<> no longer have the needed visibility of the inheritance relationship between Document and ExecutionContext to be allowed to perform the cast. Added a new Document::ToExecutionContext() helper, and changed implicit upcasts to use that explicitly. This intentionally does not use the existing GetExecutionContext() that Document inherits from Node. ToExecutionContext() should be temporary, and and all ToExecutionContext() will be audited to determine whether they should use GetExecutionContext() or follow a different path to the LocalDOMWindow. Callers of functions that Document inherited from ExecutionContext were handled case by case. For cases where many callers were using the inherited function, I've added a helper on Document. For other cases, the call now requires a Document::ToExecutionContext(). Bug: 1029822

Fixed #include path. Converted both patches to an override.

Chromium change: https://chromium.googlesource.com/chromium/src/+/f81f0d5d17c037c5866b8808322931f313b796e1 commit f81f0d5d17c037c5866b8808322931f313b796e1 Author: Peter Kasting <[email protected]> Date: Wed Mar 11 01:51:08 2020 +0000 Rename MaterialDesignController to TouchUiController. Also moves this to ui/base/pointer/, and while I'm touching all the lines anyway, renames GetInstance() to Get(). Bug: 940769

Use const &.

Chromium change: https://chromium.googlesource.com/chromium/src/+/a11361ad301b54774036b3f34856dd647747d6a1 commit a11361ad301b54774036b3f34856dd647747d6a1 Author: Clark DuVall <[email protected]> Date: Thu Feb 20 22:14:27 2020 +0000 Move PermissionContextBase to //components/permissions There is a slight difference in the code after refactoring: PermissionContextBase::IsPermissionAvailableToOrigins() now uses PermissionsClient::CanBypassEmbeddingOriginCheck() which checks both if the requesting scheme was chrome-extension or if the embedding origin was chrome://newtab. This is slightly different from the existing logic which only checks for chrome-extension. I believe this should be fine, since content::IsOriginSecure() returns true for chrome://newtab anyway. This small change allows us to use CanBypassEmbeddingOriginCheck() in PermissionContextBase::DecidePermission() as well, and avoids adding another method to PermissionsClient. Bug: 1025609

Chromium change: https://chromium.googlesource.com/chromium/src/+/600abea8ab84ba57622c7877a84777f0c1bb273b commit 600abea8ab84ba57622c7877a84777f0c1bb273b Author: Clark DuVall <[email protected]> Date: Mon Mar 23 16:16:17 2020 +0000 Move GeolocationPermissionContext to //components/permissions This breaks out embedder-specific logic into a Delegate class which is implemented in //chrome. The Delegate can then be passed to the GeolocationPermissionContext in the constructor. This is the first permission context moved to //components/permissions. I created a new subdirectory there (contexts/), so we can separate DEPS that are only needed for permission contexts from DEPS needed for the core permissions code. All the unit tests were moved except for a couple that were specific to the //chrome version of the delegate. Bug: 1025609, 1025625

It's been turned on by default for some time. Chromium change: https://chromium.googlesource.com/chromium/src/+/dc818313c5a95f9d0dcee04349532ef7ac6363b8 commit dc818313c5a95f9d0dcee04349532ef7ac6363b8 Author: Christopher Thompson <[email protected]> Date: Tue Feb 18 23:26:17 2020 +0000 Remove SimplifyHttpsIndicator feature/flag SimplifyHttpsIndicator has been default enabled for a while, and the flag expired in M-76. This removes the feature and flag, and the logic for the disabled path. This also simplifies how the display and accessibility text are generated now that there are fewer edge cases to handle, removing the SecureChipText struct in favor of separating the logic of GetSecureDisplayText() and GetSecureAccessibilityText(). Accessibility text now defaults to the display text, except for specific hard-coded exceptions (i.e., SECURE and EV_SECURE states won't have display text, so GetSecureAccessibilityText() specifies their accessibility text).

Due to the Chromium change below, AutocompleteController now has an inner Observer class some of whose methods take AutocompleteController as a parameter. This means we can no longer just redefine AutocompleteController to BraveAutocompleteController in classes that created AutocompleteController and implemented its observer. Instead of patching each of these classes, removed the overrides and patched a single place in AutocompleteController. Chromium change: https://chromium.googlesource.com/chromium/src/+/c9d02005c7893e5fe1ad24df3f1041224ab61c4c commit c9d02005c7893e5fe1ad24df3f1041224ab61c4c Author: Tommy C. Li <[email protected]> Date: Thu Mar 19 22:44:02 2020 +0000 [omnibox] Combine AutocompleteController observer classes This CL combines AutocompleteControllerDelegate and OmniboxControllerEmitter::Observer classes into a single AutocompleteController::Observer class. This is because these two classes are essentially the same, both observing the AutocompleteController. In the future, we can also make OmniboxControllerEmitter itself an instance of AutocompleteController::Observer, because it too, is essentially an observer class that's a KeyedService. The ultimate goal is to hook up the Android omnibox and NTP realbox to the chrome://omnibox debug surfaces. This refactor is to pave the way for that. See the bug for the full engineering plan on how to get there. Bug: 1058486

Chromium changes: https://chromium.googlesource.com/chromium/src/+/439a8dd6a860f5dd25d174b4ffb170a7dc531e4d commit 439a8dd6a860f5dd25d174b4ffb170a7dc531e4d Author: Thomas Lukaszewicz <[email protected]> Date: Thu Mar 12 17:58:27 2020 +0000 Updated Tab color ids Updated color ids for tab background and foreground colors. New tab ids describe the specific tab state they represent. These ids will help in transitioning over to Color Pipeline in future changes. Bug: 1056916 https://chromium.googlesource.com/chromium/src/+/ab2ca22fb75c61f7167e9b20ac88cc7a85c3be6b commit ab2ca22fb75c61f7167e9b20ac88cc7a85c3be6b Author: Thomas Lukaszewicz <[email protected]> Date: Mon Mar 16 19:30:47 2020 +0000 Consistent naming for COLOR_FRAME, simplified GetTabBackgroundColor() Updated COLOR_FRAME ThemeProperty color ids to match the naming convention used for tab background and foreground color ids. Simplified color calculation logic in GetTabBackgroundColor(). Bug: 1056916

Chromium change: https://chromium.googlesource.com/chromium/src/+/5a7ac1444c5b0a691aa480374c6e390f3fda9741 commit 5a7ac1444c5b0a691aa480374c6e390f3fda9741 Author: Jiewei Qian <[email protected]> Date: Thu Feb 27 07:04:28 2020 +0000 content_settings: add force allow origins This CL adds support to allow individual origins in content settings. Also force allow chrome-untrusted://terminal origin to Clipboard API. Bug: 1035255

Chromium change: https://chromium.googlesource.com/chromium/src/+/5ca4ae16c0c1fe5e53de615ea680ff5779ab2dc4 commit 5ca4ae16c0c1fe5e53de615ea680ff5779ab2dc4 Author: Clark DuVall <[email protected]> Date: Wed Feb 19 22:25:27 2020 +0000 Move PermissionRequestManager to //components/permissions This required moving a few other classes: - NotificationPermissionUiSelector - PermissionPrompt - MockPermission* The GetDisplayNameOrOrigin() method which used to be part of PermissionPrompt::Delegate was moved to PermissionPromptBubbleView since that is the only place it's used. A set of unit tests was left in chrome which tests chrome-specific behavior of the PermissionRequestManager. The rest of the tests were moved into the component. Bug: 1025609

Chromium change: https://chromium.googlesource.com/chromium/src/+/aa4f7b3f23460707dea0d73ca9dbbd5d9aff8c8a commit aa4f7b3f23460707dea0d73ca9dbbd5d9aff8c8a Author: Nicolás Peña Moreno <[email protected]> Date: Thu Feb 27 18:34:26 2020 +0000 Remove Time To Interactive plumbing to the browser process TTI should not be used as a RUM metric. This CL removes the plumbing of TTI and related values from the renderer to the browser process. It also removes the UMA and UKM histograms that were using it. Bug: 1055806

Switched to using ResourceLoadInfo.request_destination. Chromium change: https://chromium.googlesource.com/chromium/src/+/433f710a959de22379e68221e250bab51be2ca68 commit 433f710a959de22379e68221e250bab51be2ca68 Author: Kinuko Yasuda <[email protected]> Date: Fri Feb 14 02:11:58 2020 +0000 Deprecate ResourceType in ResourceLoadInfo and ExtraRequestCompleteInfo - blink::mojom::ResourceType is deprecated, see crbug.com/960143 - Use network::mojom::RequestDestination instead when possible - For "resource_type == kMainFrame" checks I replaced this with "request_type == kDocument" (this should mean a main-frame main resource in most cases except for Portals cases) Request destination: https://fetch.spec.whatwg.org/#concept-request-destination A PR to introduce "frame", "iframe" etc: whatwg/fetch#948 Bug: 960143

We added an extra parameter to CanonicalCookie::Create in the past. This change updates newly added code with the extra param. Chromium change: https://chromium.googlesource.com/chromium/src/+/dcf3e8ddbd1aaba4585859b713d00c9f8bc2c155 commit dcf3e8ddbd1aaba4585859b713d00c9f8bc2c155 Author: Wei Li <[email protected]> Date: Tue Mar 10 04:43:38 2020 +0000 [HaTS] Stop when the survey reaches its capacity Added a check for the survey's status. When the survey is not reachable or over its capacity, we won't show the HaTS bubble any more. Also, we will record the over capacity information so we won't need to check it again. BUG=1048385

Chromium change: https://chromium.googlesource.com/chromium/src/+/0a0e3c94ef825809e27ed8ec4a57c01d28c491f5 commit 0a0e3c94ef825809e27ed8ec4a57c01d28c491f5 Author: Karandeep Bhatia <[email protected]> Date: Fri Mar 20 11:25:41 2020 +0000 DNR: Consolidate how ruleset checksums are stored in prefs. Currently the ruleset checksum for each extension using the declarativeNetRequest API is stored as an entry corresponding to the "dnr_ruleset_checksum" or "dnr_dynamic_ruleset_checksum" key. This CL replaces them with the "dnr_static_ruleset" and "dnr_dynamic_ruleset" keys respectively, corresponding to which we store a dictionary mapping ruleset IDs to their prefs. The prefs for each ruleset is a dictionary storing just the ruleset checksum for now. This CL helps move the code away from the assumption of a single static ruleset and will aid in the transition towards multiple static rulesets. A side effect of this change is that existing extensions using declarativeNetRequest will fail to load their rulesets with an install warning. Users will have to reinstall the extension. However that's ok given that the API is only in beta and has seen limited usage as of now. BUG=754526

Chromium change: https://chromium.googlesource.com/chromium/src/+/307321d474256f41b12b53220e4dec1f2d6fdba8 commit 307321d474256f41b12b53220e4dec1f2d6fdba8 Author: Keita Suzuki <[email protected]> Date: Thu Mar 19 01:30:30 2020 +0000 [WebSocket] Add support to consume Datapipe in network service This commit adds support to network service to consume websocket frame data from mojo datapipe produced from blink. To achieve this, this commit adds a new message SendMessage() in mojo WebSocket interface. It also adds SimpleWatcher to watch the consumer and be notified when needed, and add callback function OnReadable() to support this. This commit also adds ReadAndSendFrameFromDataPipe() to actually consume data from the datapipe. The producer side of the datapipe and the caller of SendMessage() are not implemented yet for security review. WIP CLs are uploaded here: https://chromium-review.googlesource.com/c/chromium/src/+/2082869 https://chromium-review.googlesource.com/c/chromium/src/+/2083777 Design Doc: https://docs.google.com/document/d/1YWj1z9r8wxemGdod6S2tkchudhp6PvNaH3qSO0oucfY/ Bug: 1056030

Chromium change: https://chromium.googlesource.com/chromium/src/+/29015bf18a3fc97518d0613937f4703aa8cd4d82 commit 29015bf18a3fc97518d0613937f4703aa8cd4d82 Author: Nic Champagne Williamson <[email protected]> Date: Sat Feb 8 02:09:35 2020 +0000 Reland "Add Windows high contrast support to the toolbar button icons" This is a reland of 26a7b762471459c204a89360aa6653e887a84a78 The fix for the button showing up as disabled when a new widget gets activation (from a bubble, for example) is to have the buttons use Widget::PaintAsActive() instead of Widget::IsActive() when calculating the visual state. As part of this fix, we also need the buttons to listen to when PaintAsActive changes, as opposed to when Activation changes. Old workarounds have been removed as part of this fix. Original change's description: > Add Windows high contrast support to the toolbar button icons > > This change adds different foreground icon colors to the toolbar buttons > for the hovered and pressed states when the high contrast ink drop > feature is enabled. This is to support the desired platform high contrast > colors. Future work will add foreground color support to other buttons. > > New theme properties were added to support the additional _HOVERED and > _PRESSED state high contrast colors. When not in high contrast, these > are the same as the normal icon color. In high contrast (+ flag) they > return the selected text HC color. These new colors are used to create > images in the toolbar buttons for the various button states. > > New helper functions we added to ToolbarButton to simplify setting the > images for the different button states, including one that just uses > the standard colors returned by |GetForegroundColor|. > > In the future, we might want to do work to allow icons to be separated > from colors to allow for easier recoloring. > > Bug: 776871

Chromium changes: https://chromium.googlesource.com/chromium/src/+/6176b1d2cb6da6eac04ded7c013b5fcace9e19ca commit 6176b1d2cb6da6eac04ded7c013b5fcace9e19ca Author: John Smith <[email protected]> Date: Fri Mar 6 21:56:53 2020 +0000 Replace NativeThemeDarkAura with platform native themes for incognito. NativeThemeDarkAura creates some complexity in other parts of the code where we need to be aware of high/increased contrast colors and changes. Removing it and replacing it with a version of the platform native theme would allow us to remove all of the logic where we call GetInstanceForNativeUi without losing any of the benefits that we get from it. This streamlines the code as we move towards the Color Pipeline. This adds an additional instance to the NativeThemes, GetInstanceForDarkUI, which is a version of the platform native theme that would be forced to use only dark mode. It also avoids setting up any links to the webinstances in order to not pollute their state. The IsForcedDarkMode behavior was not used or changed as that flag is meant to override any other behavior. We would still want to be able to apply high contrast where appropriate in incognito mode. Additionally, this fixes an issue where the IncreasedContrastThemeSupplier was not being removed correctly on native theme changes. See discussion in https://chromium-review.googlesource.com/c/chromium/src/+/2068882 for the additional context for this change. Bug: 1003612, 953978 https://chromium.googlesource.com/chromium/src/+/920433a0a4ea915610e5e7ac5755472196d58ec8 commit 920433a0a4ea915610e5e7ac5755472196d58ec8 Author: John Smith <[email protected]> Date: Wed Mar 18 18:15:52 2020 +0000 Remove NativeThemeDarkAura files and clean up remaining refs After https://chromium-review.googlesource.com/c/chromium/src/+/2079840, the NativeThemeDarkAura was almost entirely replaced by a forced to dark version of the platform native theme. This change cleans up the remaining usages as well as removing the files and any straggling includes and build references. Bug: 1058945

Chromium change: https://chromium.googlesource.com/chromium/src/+/88ecfb08c25630c810301a8449c40275d6bf8352 commit 88ecfb08c25630c810301a8449c40275d6bf8352 Author: Thomas Lukaszewicz <[email protected]> Date: Thu Feb 27 15:12:53 2020 +0000 Fixed color management for sync and avatar icons in profile menus. Removed the need to use the global GetInstanceForNativeUi() call to get required colors when constructing avatars and sync icons for profile menu views. Also updated the profile menus such that their sync and avatar icons are updated appropriately on theme changes. Performed some basic cleanup, moved some functions into the base class. Bug: None

Chromium change: https://chromium.googlesource.com/chromium/src/+/888af74006ea1c4ee9907d18c8df2a7ca424eab9%5E%21/#F5 commit 888af74006ea1c4ee9907d18c8df2a7ca424eab9 Author: Thomas Lukaszewicz <[email protected]> Date: Thu Feb 27 15:47:31 2020 +0000 Removed remaining use of GetInstanceForNativeUi() from profile Menu. Removed remaining use of global NativeTheme accessor from profile menu and added color update capability on theme change. Fixed spacing on HoverButtons taking image views for consistency with other constructors. Bug: None

Chromium change: https://chromium.googlesource.com/chromium/src/+/510a2977507625a53c84947b4238ad592d734f39 commit 510a2977507625a53c84947b4238ad592d734f39 Author: Jason Lin <[email protected]> Date: Fri Mar 20 03:14:06 2020 +0000 crostini: remove irrelevant items from terminal's tab menu Some of the default tab menu items (e.g. reload, move to existing window) does not make sense or work well with the terminal SWA, so we want to remove them. This CL adds GetTabMenuModelFactory() to AppBrowserController to allow an app to specify the tab menu model that it wants. Before screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=438083&signed_aid=ucqPxHzsGWc98617EvvGUQ==&inline=1 After Screenshot: https://bugs.chromium.org/p/chromium/issues/attachment?aid=438084&signed_aid=R3gAlYCzETMUFNVq8NvAxw==&inline=1 Bug: 1060861

…4103.14.

Chromium change: https://chromium.googlesource.com/chromium/src/+/1be6a9e57fef1601646f8528d6c466f92cb32b39 commit 1be6a9e57fef1601646f8528d6c466f92cb32b39 Author: Wenyu Fu <[email protected]> Date: Thu Apr 2 16:40:08 2020 +0000 Decouple browser.homepage and browser.partnercustomizations Bug: 1052060

Chromium change: https://chromium.googlesource.com/chromium/src/+/9539c5c3af1b6e9c524db96e9cc11ab61f420ccb commit 9539c5c3af1b6e9c524db96e9cc11ab61f420ccb Author: Wenyu Fu <[email protected]> Date: Wed Apr 1 17:46:56 2020 +0000 Reland "Move settings.homepage to homepage" This reverts commit e6de1039950b1fd5cfef266370a9d3f3989fbbf9. Reason for revert: The crash was caused by a xml text failure. The original change also delete one of the test file unintentionally. A fix will be update as a patch set of this CL. Original change's description: > Revert "Move settings.homepage to homepage" > > This reverts commit e2054b9b309dad3fc8b526fe7ba2a57037c2b661. > > Reason for revert: this CL cause crashing. Tracked in crbug.com/1062959 > > Original change's description: > > Move settings.homepage to homepage > > > > Moving Homepage related settings code to homepage.settings package > > > > Change-Id: Iaf198f4a25cc03b32a1de997577d466916470437 > > Bug: 1052060 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095468 > > Commit-Queue: Wenyu Fu <[email protected]> > > Reviewed-by: Theresa <[email protected]> > > Cr-Commit-Position: refs/heads/master@{#751162} > > [email protected],[email protected],[email protected] > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1052060

The compilation command line is too long (exceeds 8,192 chars) for some compile commands. This is an attempt to shorten it. Also, turned down the verbosity of output.

Chromium change: https://chromium.googlesource.com/chromium/src/+/9d383314fa8cbde76f36e5f9b138cd8a844f956c commit 9d383314fa8cbde76f36e5f9b138cd8a844f956c Author: Nicolas Arciniega <[email protected]> Date: Tue Feb 18 23:36:41 2020 +0000 Refactor ConfiguredProxyResolutionService::Request This change moves out ConfiguredProxyResolutionService::Request into its own file and renames it to ProxyResolutionRequest. This will be necessary later on when we create a second version of the ConfiguredProxyResolutionService under a base ProxyResolutionService that relies completely on system APIs. In that second version, we will also want to track the status of a proxy resolution request. This change is intended to introduce zero functional changes. It is a pure refactor change. Bug: 1032820

Chromium change: https://chromium.googlesource.com/chromium/src/+/41b07ab53490d3aa411ebc41c49b1baf4b5015f5 commit 41b07ab53490d3aa411ebc41c49b1baf4b5015f5 Author: Toby Huang <[email protected]> Date: Fri Mar 27 21:40:30 2020 +0000 Unit tests for supervised users policy allowlist extensions install In response to the COVID-19 crisis, we launched the "extensions lite" feature that enables supervised users to install extensions from the ExtensionInstallWhitelist policy. In the hurry, we didn't add unit tests for the original CL. This CL adds unit tests for crrev.com/c/2109977. Bug: 1063099

Chromium change: https://chromium.googlesource.com/chromium/src/+/8c4446dcf4ef6d9d58bb7f578f2946eb1638ddb8 commit 8c4446dcf4ef6d9d58bb7f578f2946eb1638ddb8 Author: Lukasz Anforowicz <[email protected]> Date: Wed Mar 11 22:16:42 2020 +0000 Splitting context_menu_params.h into separate browser VS common parts. This CL takes //content/public/common/context_menu_params.h and splits it into: 1. //content/public/common/*untrustworthy*_context_menu_params.h which contains: - UntrustworthyContextMenuParams - CustomContextMenuContext (type of a field under UntrustworthyContextMenuParams) 2. //content/public/*browser*/context_menu_params.h which contains: - ContextMenuParams Bug: 534561

Now returns Widget*. Chromium change: https://chromium.googlesource.com/chromium/src/+/3ece94e3d603017331c567f6e727c77d444dbebc commit 3ece94e3d603017331c567f6e727c77d444dbebc Author: Elly Fong-Jones <[email protected]> Date: Wed Feb 5 16:29:24 2020 +0000 cbui: port PermissionBubbleInteractiveUITest to Win/Linux This change moves these tests from Mac-only to all Views platforms, although they are currently disabled on Windows & Linux because of the linked bug. To do this, the tests are rewritten to use Views APIs rather than directly using NSWindow, and PermissionRequestManagerTestApi is modified to deal in Widgets rather than NativeWindows. This change also removes PermissionBubbleViewsInteractiveUITest, which was an incomplete copy of PermissionBubbleInteractiveUITest dating to the initial MacViews secondary UI work, and also has never run on any non-Mac platform. Bug: 866878

Chromium change: https://chromium.googlesource.com/chromium/src/+/9d5dd280857629d9689bb125b66ddf7ac6b3dc09 commit 9d5dd280857629d9689bb125b66ddf7ac6b3dc09 Author: Wez <[email protected]> Date: Mon Feb 10 17:21:22 2020 +0000 Reland "[base] Make test Run() timeouts fatal unless using GTest." This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/1932464 with a missing #include added to assistant_test_mixin.cc. The Run() timeouts set for tests now default to crashing the calling process. This ensures that Run() timeouts cause visible failures regardless of whether the calling suite uses GTest. Suites which do use GTest can switch to having timeouts reported via GTEST_FAIL() by calling: base::test::ScopedRunLoopTimeout::SetUseGTestFailOnTimeout(); Test suites derived from base::TestSuite will have this option set for them as part of the TestSuite initialization. The RunLoop::ScopedRunTimeoutForTest helper is moved to base::test::ScopedRunLoopTimeout, to allow it to have GTest dependencies. Bug: 1021777, 1014767

GURL constructor uses scheme registry which now DCHECKs if accessed before being initialized with schemes. Converted BraveStatsUpdater::g_base_update_url_ to std::string. Converted SuggestedSitesProvider::suggested_sites_ to method local static. Converted oauth_url in binance_service.cc to const char[]. Also, moved inside functions in several unit tests. Chromium change: https://chromium.googlesource.com/chromium/src/+/2add7d44778f7be638639aeb26a3b14f0b222e09 commit 2add7d44778f7be638639aeb26a3b14f0b222e09 Author: Michael Thiessen <[email protected]> Date: Wed Feb 5 13:49:38 2020 +0000 Lock SchemeRegistry on first use. This change locks the SchemeRegistry on first use, which required refactoring url_util.cc to differentiate between SchemeRegistry use for adding Schemes, and SchemeRegistry use for using Schemes. Tests can now only modify schemes after initialization by calling url::UnlockForTests(), which creates a scoped object that resets the schemes, so tests can't mistakenly leave global scheme state modified. This change required changes to browser startup to decouple scheme registration from ContentMain, found here: https://chromium-review.googlesource.com/c/chromium/src/+/1945926 Doc: https://docs.google.com/document/d/1kDKqBaq-b6EbUm0F4ea7ARoksUcj1KUx3qxFuSXEwM4/edit Bug: 783819

This file was renamed to import_data_handler.cc, but the copy with the old name wasn't removed.

Added new method implementation. Chromium change: https://chromium.googlesource.com/chromium/src/+/82e2f8dbfd7ab938e6cb0741f5033d056efe72bd commit 82e2f8dbfd7ab938e6cb0741f5033d056efe72bd Author: Caroline Rising <[email protected]> Date: Tue Apr 7 00:40:25 2020 +0000 Fix bug in extension context menu pinning options. This cl fixes a bug where pinned extensions where stored as the popped out extension when a popup was showing. This change also forces extension popups to close when an extension context menu is triggered, doing this makes behavior the same across all platforms and fixes a crash where the user could try to pin a popped out extension twice. Bug: 1056597

Chromium change: https://chromium.googlesource.com/chromium/src/+/e66c244ff77a19c82e2c93332aae310506296a7e commit e66c244ff77a19c82e2c93332aae310506296a7e Author: Theresa Wellington <[email protected]> Date: Fri Feb 7 01:17:26 2020 +0000 [Android] Remove dark mode build flag Remove the dark mode build flag and merge res_night/ into normal res/ directory. Also removes the dark mode flag from about://flags. BUG=936275

BlinkTestHostMsg has been converted to Mojo. We used that IPC method for BraveViewHostMsg_JavaScriptBlocked, BraveViewHostMsg_FingerprintingBlocked, and BraveFrameMsg_AllowScriptsOnce messages. Changed our code to use ChromeMsgStart and FrameMsgStart. Chromium change: https://chromium.googlesource.com/chromium/src.git/+/31755f407c3da7280224c677ce62768d8c858a50 commit 31755f407c3da7280224c677ce62768d8c858a50 Author: Gyuyoung Kim <[email protected]> Date: Thu Mar 12 10:27:02 2020 +0000 Convert BlinkTestHostMsg_PrintMessage to Mojo This CL converts BlinkTestHostMsg_PrintMessage to BlinkTestClient interface. But, BlinkTestRunner::PrintMessage needs to send a message only when it's on the mainframe in order to sync with the existing behavior. Like BlinkTestHostMsg_ResetDone conversion, this message has been sent to the main frame. So, this CL moves |is_secondary_window| from WebTestRenderFrameObserver to BlinkTestRunner. Additionally, this CL removes blink_test_messages.h/cc files and related things(e.g. BlinkTestMsgStart) finally. Bug: 1039247, 1059322

Chromium change: https://chromium.googlesource.com/chromium/src/+/f7db9c2bbd0cd5108a93fd77e2c68c464062826b commit f7db9c2bbd0cd5108a93fd77e2c68c464062826b Author: Etienne Pierre-doray <[email protected]> Date: Thu Mar 19 18:54:05 2020 +0000 [Startup metrics]: new NonEmptyPaint3 uses application start. NonEmptyPaint3 now compares to application start time instead of process creation time. This CL refactors startup.LoadTime steps to be cross-platform, with: - process creation - application start time - ChromeMain() time This CL also updates a histograms that measure delta between these for validation. The metric is behaving weird on mac. It's less error prone to use TimeTicks sampled early than aligning clocks. Context: https://groups.google.com/a/google.com/g/chrome-catan/c/BhJOc7JIYeY

The original code resulted in an error: contribution.cc(206,48): error: loop variable 'value' of type 'const std::pair<std::string, uint32_t> &' (aka 'const pair<basic_string<char, char_traits<char>, allocator<char>>, unsigned int> &') binds to a temporary constructed from type 'std::__1::__map_iterator<std::__1::__tree_iterator<std::__1::__value_type<std::__1::basic_string<char>, unsigned int>, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, unsigned int>, void *> *, long long>>::reference' (aka 'pair<const std::__1::basic_string<char>, unsigned int> &') [-Werror,-Wrange-loop-construct] for (std::pair<std::string, uint32_t> const& value : retry_timers_) { ^ ../../brave/vendor/bat-native-ledger/src/bat/ledger/internal/contribution/contribution.cc(206,8): note: use non-reference type 'std::pair<std::string, uint32_t>' (aka 'pair<basic_string<char, char_traits<char>, allocator<char>>, unsigned int>') to make construction explicit or type 'const std::__1::__map_iterator<std::__1::__tree_iterator<std::__1::__value_type<std::__1::basic_string<char>, unsigned int>, std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char>, unsigned int>, void *> *, long long>>::value_type &' (aka 'const pair<const std::__1::basic_string<char>, unsigned int> &') to prevent copying for (std::pair<std::string, uint32_t> const& value : retry_timers_) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated.

Chromium change: https://chromium.googlesource.com/chromium/src/+/5674a41893ed2979bceb8a2cd444b7616706f58e commit 5674a41893ed2979bceb8a2cd444b7616706f58e Author: Alex Ilin <[email protected]> Date: Tue Feb 25 18:03:25 2020 +0000 [profiles] Do not create profiles outside of user data directory Chrome profiles must always be located inside the user data directory. Using "profile-directory" command line flag, the user can violate this requirement. Initialization of a profile outside of the user data directory would eventually fail. But it would happen after a profile object and all files inside of the profile are created. This CL adds a check to profile creation functions that will return nullptr if a profile directory is disallowed. A profile directory is allowed if its direct parent is the user data directory. This CL also extends the expiration date of Profile.InitProfileUserPrefs.OutsideUserDir and Profile.GetProfileInfoPath.OutsideUserDir histograms to verify that they are no longer recorded after this fix. Bug: 981374, 1053107

Chromium change: https://chromium.googlesource.com/chromium/src/+/aa27e241dca7395adb048620f9c5685798161c96 commit aa27e241dca7395adb048620f9c5685798161c96 Author: Rushan Suleymanov <[email protected]> Date: Fri Feb 28 11:28:36 2020 +0000 Reland "Verify consistency between sync and sign-in account IDs" This reverts commit 9f5f561e4b2b6cb5a11813bc47d7d08f08a223ea. Reason for revert: reland this patch after fixing of DCHECK failures at crrev.com/c/2061751. Original change's description: > Revert "Verify consistency between sync and sign-in account IDs" > > This reverts commit caf8eebf99fa96125a1b0ae48392e68b7dc2ce0b. > > Reason for revert: suspect of running into sync protocol violations and > the corresponding DCHECK failures. > > This CL reverts a preference being introduced without the corresponding > cleanup logic; but we intend to reland this patch anyway. > > Original change's description: > > Verify consistency between sync and sign-in account IDs > > > > Local sync metadata belongs to one user account. Due to the distributed > > nature of the locally persisted sync metadata, the cache GUID is used > > as "epoch" to detect mismatched in edge cases like the browser crashing > > during shutdown and before I/O gets flushed. > > > > However, prior to this patch, the cache GUID itself has no safety > > mechanism to detect it maps to the intended account ID. In this patch, > > a new SyncPref is introduced to achieve that, in away that both prefs > > (cache GUID and account ID) are stored atomically. > > > > Because the pref is newly-introduced, migration logic is introduced to > > populate it for the first time if initially empty. > > > > Bug: 1046237, 1021527, 1048771

Chromium change: https://chromium.googlesource.com/chromium/src/+/7f31c1d3cb9da031f1c13f0eb9b2b328136c3750 commit 7f31c1d3cb9da031f1c13f0eb9b2b328136c3750 Author: Tom Anderson <[email protected]> Date: Wed Mar 11 01:14:30 2020 +0000 Add DCHECK to ensure OnThemeChanged() overrides call their parents A very commonly recurring bug is forgetting to call ParentClass::OnThemeChanged() in DerivedClass::OnThemeChanged(). This CL adds a DCHECK that attempts to address this issue. In the process, many missing OnThemeChanged() calls were discovered. It's probable that some of these may cause unexpected colors in certain UI that was relying on the hardcoded default colors. BUG=None

Chromium change: https://chromium.googlesource.com/chromium/src/+/49bf6e021eb90a3486d2b1ccac933a071b755b8a commit 49bf6e021eb90a3486d2b1ccac933a071b755b8a Author: Bret Sepulveda <[email protected]> Date: Mon Feb 17 15:17:39 2020 +0000 Prevent mouse events from triggering hover cards in browser tests. If the mouse happens to be in exactly the wrong position it triggers a hover card, which can cause strange failures in some tests, especially on bots where the mouse can cause the test to fail repeatedly until it happens to be moved. To fix this, this patch prevents Tab::OnMouseEntered from triggering hover cards when running an InProcessBrowserTest. Also changes hover card browser tests to call TabStrip::UpdateHoverCard instead of Tab::OnMouseEntered to get around that method now being disabled, and does some light refactoring. Bug: 1050012

This is done to shorten the command line.

Ensures compatibility with c83 optimized compile

Accounts for DOM changes in c83 vs c82

When all unit test are in the same suite, all the -D and -I add up to a command line that is too long on Windows. Split rewards and ads to a separate build target in vendor/test.

Chromium change: https://chromium.googlesource.com/chromium/src/+/70e8efce87a2610ffbbe2ee3661e0ca01470ce6b commit 70e8efce87a2610ffbbe2ee3661e0ca01470ce6b Author: Olivier Tilloy <[email protected]> Date: Wed Apr 1 22:13:03 2020 +0000 Initial integration of snap packaging. This adds logic to the linux_package template to generate a snap package from build artifacts, similar to what is done for .deb and .rpm packages. BUG=1055026

Chromium changes: https://chromium.googlesource.com/chromium/src/+/90b95abb9b18974c90ddba4c638dd7cefd4feae7 commit 90b95abb9b18974c90ddba4c638dd7cefd4feae7 Author: Ken Rockot <[email protected]> Date: Thu Apr 2 20:07:29 2020 +0000 Extract mojom parser from bindings generator This extracts the mojom parsing logic from mojom_bindings_generator.py into a new mojom_parser.py script within the mojom tool directory. Apart from simply moving the parsing logic to a new script, this also changes how the parse result is persisted by an intermediate build step for subsequent build steps to consume. Prior to this change, the parsing step emitted a ".p" file for each processed .mojom file. This was nothing more than a serialized version of the parsed AST with [EnableIf] feature filtering applied. Every subsequent step for the mojom in question would load this AST, then recursively process its import dependencies while loading their ASTs in turn, before finally processing all of the aggregated data (resolving references, computing field packing data, etc) to produce a Module object suitable for bindings generation. This CL rolls most of that processing into the parsing step (with more to follow in future CLs), and the resulting computed Module object is persisted to a ".mojom-module" file. To generate bindings for a given .mojom file, the generator can simply call Module.Load() on the corresponding .mojom-module produced by the parser. The loaded Module is sufficient to inform code generation with no need to resolve dependencies, process other modules, or perform other complex computations on the model. Each mojom-module is thus entirely self-contained, replicating the full contents of all transitive import dependencies. This means the build consumes more disk space with intermediate build artifacts, but it also means generation steps are faster and simpler. This CL should result in no net changes to the final build outputs. Bug: 1060471 https://chromium.googlesource.com/chromium/src/+/77cb7c1e2a6250342e3b9349fd0d1f02eb676032 commit 77cb7c1e2a6250342e3b9349fd0d1f02eb676032 Author: Ken Rockot <[email protected]> Date: Fri Mar 13 03:19:49 2020 +0000 Fix mojom parser tests This fixes all the existing mojom parser tests that are still meaningful and applicable and deletes the rest. This also fixes or (where appropriate) disables any outstanding pylint issues in these flies. The tests can be run locally with: python -m unittest discover \ -s mojo/public/tools/mojom/ -p "*_unittest.py" A follow-up CL will introduce a general-purpose script for registering and running all Python-based tests related to Mojo tools so that they can run on the CQ as well. Bug: 1060473

Instead moved copying to brave-browser/lib/util.js util.copyRedirectCC.

Part of the preceding commit "simplify patches for max expiration date".

…ailed Issue fixed in PR #5612

Caused by latest master pull to cr83

Will crash running BraveProfileManagerTest.ProxyConfigMonitorInTorProfile unit test if we do not instantiate TorProfileService, because we will need TorProfileService to create the proxy config service for Tor profile.

This feature was disabled by default in C81, but is enabled by default in C83. It causes a crash when navigating to brave://settings/payments. commit f8d01800e4c08fb9ed7af6a5446f14553a0e2c6e Author: Jared Saul <[email protected]> Date: Mon Mar 23 22:53:41 2020 +0000 [AF] Enable AutofillEnableAccountWalletStorage by default Also cleans up the fieldtrial_testing_config entry for the SyncButterWallet launch now that it's enabled ToT (and 100% launched). Per request, not going to clean up the code usage of the flag quite yet because Butter for Mobile may be coming in the near future. Bug: 983940

Doesn't seem to work for unit tests binary.

…gation, use js overrides

This was a leftover from the CreateCookie patches cleanup.

Related to recent master pull

Caused by latest master pull to cr83

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade from Chromium 81 to Chromium 83 #5102

Upgrade from Chromium 81 to Chromium 83 #5102

Commits on May 26, 2020