Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings: Remove "attempts" string from fingerprinting options #5140

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

cezaraugusto
Copy link
Contributor

Close brave/brave-browser#7949

Submitter Checklist:

Test Plan:

  1. Go to brave://settings/shields
  2. Section on fingerprinting should match screenshot

Screen Shot 2020-04-01 at 19 34 44

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@cezaraugusto cezaraugusto self-assigned this Apr 1, 2020
@cezaraugusto
Copy link
Contributor Author

Also see brave/brave-browser#7949 (comment) which has @karenkliu instructions.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change "Device recognition" label to "Fingerprint"
2 participants