Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes duplicate/bad confirmations retry logic - 1.7.x #5262

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Fixes duplicate/bad confirmations retry logic - 1.7.x #5262

merged 1 commit into from
Apr 20, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Apr 15, 2020 •
edited by kjozwiak
Loading

Uplift of https://github.com/brave/brave-core/pull/5260/files
Resolves brave/brave-browser#9242

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.7.x - Release Hotfix 1 milestone Apr 15, 2020
@tmancey tmancey requested a review from a team April 15, 2020 21:28
@tmancey tmancey self-assigned this Apr 15, 2020
@tmancey tmancey changed the title Fixes duplicate/bad confirmations should not retry when creating a confirmation - 1.7.x Fixes duplicate/bad confirmations retry logic - 1.7.x Apr 16, 2020
@tmancey tmancey force-pushed the issues/9242-1.7.x branch 4 times, most recently from 38f5b9b to e13914b Compare April 16, 2020 14:09
@bsclifton
Copy link
Member

macOS actually ran great here 🎉 there was a "Publish xUnit Test" failure which is not a problem. iOS failed though, timing out during fetch ☹️

@bsclifton
Copy link
Member

Passed on all except iOS; marking skip for others and re-running

@bsclifton bsclifton added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Apr 16, 2020
@kjozwiak
Copy link
Member

Looks like iOS is failing init due to Timeout has been exceeded as per https://ci.brave.com/job/brave-browser-build-pr/job/issues%252F9242-1.7.x/6/execution/node/323/log/. I'm not sure if restarting as most PRs are failing due to this issue but giving it a shot. Hopefully it doesn't timeout as it's a bit later and there's less users using CI.

@kjozwiak
Copy link
Member

Just an FYI, #5260 hasn't landed in master.

@kjozwiak
Copy link
Member

QA verified #5260 on Nightly as per #5260.

kjozwiak
kjozwiak approved these changes Apr 20, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.7.x approved after deliberating with @brave/uplift-approvers. Please make sure that all the correct labels are being used and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit fedde28 into 1.7.x Apr 20, 2020
@kjozwiak kjozwiak deleted the issues/9242-1.7.x branch April 20, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug CI/skip-android Do not run CI builds for Android CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Milestone
1.7.x - Release Hotfix 1
Development

Successfully merging this pull request may close these issues.
3 participants
@tmancey @bsclifton @kjozwiak