-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow modification of window attributes with scriptlets #5402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Tested and verified it works as expected (current Nightly versus the binaries spit out by PR builder)
- Code changes look good!
- CI looks good:
- macOS had a
test-install
failure (known) - Android has failing unit tests (known and broken on master, not related to this; folks working on fixing)
- Windows has a specific unit test failure that would be solved if this was rebased
- macOS had a
Ready to merge 👍
* return { 'color': 'Impossible value' }; | ||
* } | ||
* })(); | ||
* ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to just base64 encode the actual value for next time base::Base64Encode
.
Resolves brave/brave-browser#9496
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
To manually test, visit https://www.reuters.com/article/us-health-coronavirus-usa-election/its-not-about-you-democrats-bet-trump-coronavirus-response-a-2020-winner-for-biden-idUSKCN2292UN and verify that there is no "PAID PROMOTIONAL LINKS" section at the bottom of the page after a few seconds of load time.
Reviewer Checklist:
After-merge Checklist:
changes has landed on.