Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow modification of window attributes with scriptlets #5402

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

antonok-edm
Copy link
Collaborator

@antonok-edm antonok-edm commented Apr 28, 2020

Resolves brave/brave-browser#9496

Submitter Checklist:

Test Plan:

To manually test, visit https://www.reuters.com/article/us-health-coronavirus-usa-election/its-not-about-you-democrats-bet-trump-coronavirus-response-a-2020-winner-for-biden-idUSKCN2292UN and verify that there is no "PAID PROMOTIONAL LINKS" section at the bottom of the page after a few seconds of load time.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@antonok-edm antonok-edm self-assigned this Apr 28, 2020
Copy link
Contributor

@pes10k pes10k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested and verified it works as expected (current Nightly versus the binaries spit out by PR builder)
  • Code changes look good!
  • CI looks good:
    • macOS had a test-install failure (known)
    • Android has failing unit tests (known and broken on master, not related to this; folks working on fixing)
    • Windows has a specific unit test failure that would be solved if this was rebased

Ready to merge 👍

* return { 'color': 'Impossible value' };
* }
* })();
* ```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to just base64 encode the actual value for next time base::Base64Encode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow modification of window attributes with scriptlets
5 participants