Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes only add jitter for Brave Ads token redemption when creating the timestamp #5461

Merged
merged 1 commit into from
May 10, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented May 5, 2020

Resolves brave/brave-browser#9624

Submitter Checklist:

Test Plan:

  • Confirm "Payout tokens" date in the console log does not change between browser relaunches
  • Confirm tokens are paid out on the correct date
  • Confirm dates are on average ~24 hours

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey self-assigned this May 5, 2020
@tmancey tmancey force-pushed the issues/9624 branch 2 times, most recently from fcc28c7 to e37f82c Compare May 7, 2020 11:04
@tmancey
Copy link
Collaborator Author

tmancey commented May 8, 2020

Failed CI due to known issues with iOS and rewards browser tests

@tmancey
Copy link
Collaborator Author

tmancey commented May 10, 2020

Failed CI due to known issues with brave rewards browser tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only add jitter for Brave Ads token redemption when creating the timestamp
2 participants