Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct App ID for release channel #553

Merged
merged 1 commit into from
Oct 3, 2018
Merged

Use correct App ID for release channel #553

merged 1 commit into from
Oct 3, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Oct 2, 2018

Fix brave/brave-browser#970

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy self-assigned this Oct 2, 2018
@bbondy bbondy changed the title Use correct App ID for release channel WIP: Use correct App ID for release channel Oct 3, 2018
@bbondy
Copy link
Member Author

bbondy commented Oct 3, 2018

Currently this is generating com.brave.Browser. and not com.brave.Browser, looking into why still.

@bbondy bbondy changed the title WIP: Use correct App ID for release channel Use correct App ID for release channel Oct 3, 2018
@bbondy
Copy link
Member Author

bbondy commented Oct 3, 2018

OK Fixed.

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bbondy bbondy merged commit 4d3f551 into master Oct 3, 2018
bbondy added a commit that referenced this pull request Oct 3, 2018
Use correct App ID for release channel
bbondy added a commit that referenced this pull request Oct 3, 2018
Use correct App ID for release channel
@bbondy
Copy link
Member Author

bbondy commented Oct 3, 2018

master: 4d3f551
0.56.x: c21d016
0.55.x: 9918d52

@bsclifton bsclifton deleted the apple-app-id branch October 14, 2018 05:15
@bsclifton bsclifton restored the apple-app-id branch October 14, 2018 05:16
@bsclifton bsclifton deleted the apple-app-id branch October 14, 2018 05:16
@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple app ID incorrect on release builds
2 participants