Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reverse rewrite the webtorrent URL when query string is not HT… #5595

Merged
merged 1 commit into from
May 20, 2020

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented May 19, 2020

…TP/HTTPS URL.

Resolves brave/brave-browser#9159

Submitter Checklist:

Test Plan:

  1. Access https://webtorrent.io/torrents/sintel.torrent to make sure webtorrent is enabled and loaded.
  2. Open a new tab and put chrome-extension://lgjmpdmojkpocjcopdikifhejkkjglho/extension/brave_webtorrent.html?chrome://settings/ in the URL bar, then click enter.
  3. A blank webtorrent extension page should be shown and URL stays the same as the URL in step 2.
  4. Open a new tab and put chrome-extension://lgjmpdmojkpocjcopdikifhejkkjglho/extension/brave_webtorrent.html?brave://rewards/ in the URL bar, then click enter.
  5. A blank webtorrent extension page should be shown and URL stays the same as the URL in step 4.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@feross feross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feross
Copy link
Contributor

feross commented May 19, 2020

@yrliou Thank you for completing this!

@yrliou
Copy link
Member Author

yrliou commented May 20, 2020

CI was all green in https://ci.brave.com/job/pr-brave-browser-fix_webtorrent_reverse_rewrite/1//flowGraphTable/?auto_refresh=true, but timed out on android, so I'm going to apply skip CI labels on other platforms to retry android.

@yrliou yrliou added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels May 20, 2020
@yrliou
Copy link
Member Author

yrliou commented May 20, 2020

Android passed after retried, merging.

@yrliou yrliou merged commit 52949bb into master May 20, 2020
@yrliou yrliou deleted the fix_webtorrent_reverse_rewrite branch May 20, 2020 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] [hackerone] [Security] webtorrent should clear redirect URL if not http:// or https://
2 participants