Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UI on component update (uplift to 1.10.x) #5729

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jun 3, 2020

Uplift of #5724

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team June 3, 2020 17:32
@brave-builds brave-builds self-assigned this Jun 3, 2020
@brave-builds brave-builds added this to the 1.10.x - Beta milestone Jun 3, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jun 4, 2020

Looks like test-browser failed on both Linux & macOS due to BraveRewardsBrowserTest.CheckIfReconcileWasResetEmpty as per the following:

4:33:02  Failed
14:33:02  RunLoop::Run() timed out.
14:33:02  Stack trace:
14:33:02  #0 0x55d8d4e50769 (/home/ubuntu/jenkins/workspace/pr-brave-browser-pr5724_SR_components_update_dp_1.10.x/src/out/Release/brave_browser_tests+0x5c3c768)
14:33:02  
14:33:02  [  FAILED  ] BraveRewardsBrowserTest.CheckIfReconcileWasResetEmpty, where TypeParam =  and GetParam() =  (30859 ms)

However, the above failure isn't an uplift blocker as brave/brave-browser#10032 was fixed in Nightly.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.10.x approved after deliberating with @brave/uplift-approvers. QA won't be able to run through the PR on Nightly but after discussions with @deeppandya and @srirambv, we'll merge this and QA it when we get 1.10.x release builds.

@kjozwiak kjozwiak merged commit 93a59f1 into 1.10.x Jun 5, 2020
@kjozwiak kjozwiak deleted the pr5724_SR_components_update_dp_1.10.x branch June 5, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants