Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ads rewards are not refreshed after claiming an ad grant - 1.11.x #5768

Closed
wants to merge 1 commit into from

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 8, 2020

Uplift of #5748
Resolves brave/brave-browser#10094

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.11.x - Beta milestone Jun 8, 2020
@tmancey tmancey requested a review from a team June 8, 2020 11:15
@tmancey tmancey self-assigned this Jun 8, 2020
@tmancey tmancey changed the title Fixes ads rewards are not refreshed after claiming an ad grant Fixes ads rewards are not refreshed after claiming an ad grant - 1.11.x Jun 8, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jun 9, 2020

Restarting Android due to not being able to retrieve a node and timing out after ~6hrs as per https://ci.brave.com/job/pr-brave-browser-issues-10094-1.11.x/1/execution/node/66/log/:

07:21:07  Still waiting to schedule task
07:21:07  All nodes of label ‘android-ecs’ are offline

@kjozwiak kjozwiak added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jun 9, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Jun 9, 2020

Restarting Android as test-unit timed out as per https://ci.brave.com/job/pr-brave-browser-issues-10094-1.11.x/2/execution/node/343/log/.

@kjozwiak
Copy link
Member

As per discussion with @rebron and @jsecretan, we'll let #5748 work it's way through the trains.

@kjozwiak kjozwiak closed this Jun 15, 2020
@kjozwiak kjozwiak removed request for a team, kylehickinson and NejcZdovc June 15, 2020 22:29
@kjozwiak kjozwiak removed this from the 1.11.x - Beta milestone Jun 15, 2020
@tmancey tmancey deleted the issues/10094-1.11.x branch June 11, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/ads
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants