Fixes extensions install prompt. #5772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The override of extensions install prompt text has regressed with Chromium 83 update. Removed BravePrompt that inherited from ExtensionInstallPrompt::Prompt and overrode GetDialogTitle method. Instead, renamed the original method to GetDialogTitle_ChromiumImpl and added our own GetDialogTitle. Fixes brave/brave-browser#10113 The regression is due to Chromium change that was creating ExtensionInstallPrompt::Prompt from WebstorePrivateBeginInstallWithManifest3Function::OnWebstoreParseSuccess. Chromium change: https://chromium.googlesource.com/chromium/src/+/4f35260605f0a6fa5153bcc40cc9ed7b235fddec commit 4f35260605f0a6fa5153bcc40cc9ed7b235fddec Author: Danan S <[email protected]> Date: Fri Mar 27 00:41:17 2020 +0000 Reland "Changes to Webstore Private API to support child extension installation" This relands the feature originally landed in 99ffda8ef2c76aa79923281a57c82a70e68d0d45 That CL was reverted due to an use-after-free error triggered by ExtensionWebstorePrivateApiTestChildInstallEnabled, but caused by already landed code used by the Webstore Private API. The actual fix for the use-after-free was fixed in http://crrev.com/c/2100548 That fix involved changes in the ParentPermissionDialog APIs, which are reflected in this reland CL. Original change's description: > Revert "Changes to Webstore Private API to support child extension installation" > > This reverts commit 99ffda8ef2c76aa79923281a57c82a70e68d0d45. > > Reason for revert: browser_tests failing on https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37129 and https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/18174 > > Original change's description: > > Changes to Webstore Private API to support child extension installation > > > > These changes are required in order to prompt a child user to get > > parent permission when they attempt to install an extension in the > > Chrome Webstore. > > > > This CL also enables the feature by default. > > > > Bug: 957832
mbacchi
added
CI/skip-ios
bridiver
approved these changes
Jun 9, 2020
mkarolin
added a commit
that referenced
this pull request
Jun 9, 2020
Fixes extensions install prompt.
mkarolin
added a commit
that referenced
this pull request
Jun 9, 2020
Fixes extensions install prompt.
This was referenced Jun 9, 2020
|
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#10113
Removed BravePrompt that inherited from ExtensionInstallPrompt::Prompt
and overrode GetDialogTitle method. Instead, renamed the original method
to GetDialogTitle_ChromiumImpl and added our own GetDialogTitle.
Submitter Checklist:
npm run lint)git rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist:
After-merge Checklist:
changes has landed on.